<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #666;">
<a href="https://gitlab.com/thesamesam">Sam James</a> created an issue: <a href="https://gitlab.com/gnutls/gnutls/-/issues/1341">#1341</a>
</p>
<div class="md">
<p dir="auto">Hi!</p>
<p dir="auto">Thanks for another release of GnuTLS :)</p>
<p dir="auto">3.7.4's <code>./configure</code> lacks support for <code>--{enable,disable}-gtk-doc</code>. Noticed when working on packaging 3.7.4 for Gentoo. It took me a little while to figure it out given <code>configure.ac</code> still contains:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" lang="plaintext" v-pre="true" style="border-radius: 2px; margin: 0 0 8px; padding: 8px 12px; border: 1px solid #dbdbdb;"><code><span id="LC1" class="line" lang="plaintext"></span>
<span id="LC2" class="line" lang="plaintext">dnl</span>
<span id="LC3" class="line" lang="plaintext">dnl check for gtk-doc</span>
<span id="LC4" class="line" lang="plaintext">dnl</span>
<span id="LC5" class="line" lang="plaintext">m4_ifdef([GTK_DOC_CHECK], [</span>
<span id="LC6" class="line" lang="plaintext">GTK_DOC_CHECK([1.14],[--flavour no-tmpl])</span>
<span id="LC7" class="line" lang="plaintext">],[</span>
<span id="LC8" class="line" lang="plaintext">AM_CONDITIONAL([ENABLE_GTK_DOC], false)</span>
<span id="LC9" class="line" lang="plaintext">])</span>
<span id="LC10" class="line" lang="plaintext"># needed for some older versions of gtk-doc</span>
<span id="LC11" class="line" lang="plaintext">m4_ifdef([GTK_DOC_USE_LIBTOOL], [], [</span>
<span id="LC12" class="line" lang="plaintext">AM_CONDITIONAL([GTK_DOC_USE_LIBTOOL], false)</span>
<span id="LC13" class="line" lang="plaintext">])</span></code></pre>
<copy-code></copy-code>
</div>
<p dir="auto">I realised after diffing 3.7.3 and 3.7.4's tarballs (I won't bore you with all the relevant snippets, just enough to show the issue):</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" lang="plaintext" v-pre="true" style="border-radius: 2px; margin: 0 0 8px; padding: 8px 12px; border: 1px solid #dbdbdb;"><code><span id="LC1" class="line" lang="plaintext">--- /tmp/pkgdiff/portage/net-libs/gnutls-3.7.3-r1/work/gnutls-3.7.3/aclocal.m4 2022-01-18 07:07:52.000000000 +0000</span>
<span id="LC2" class="line" lang="plaintext">+++ /tmp/pkgdiff/portage/net-libs/gnutls-3.7.4/work/gnutls-3.7.4/aclocal.m4 2022-03-17 10:11:32.000000000 +0000</span>
<span id="LC3" class="line" lang="plaintext">@@ -1611,7 +1611,6 @@ m4_include([m4/gettext.m4])</span>
<span id="LC4" class="line" lang="plaintext"> m4_include([m4/gettimeofday.m4])</span>
<span id="LC5" class="line" lang="plaintext"> m4_include([m4/gnulib-common.m4])</span>
<span id="LC6" class="line" lang="plaintext"> m4_include([m4/gnulib-comp.m4])</span>
<span id="LC7" class="line" lang="plaintext">-m4_include([m4/gtk-doc.m4])</span>
<span id="LC8" class="line" lang="plaintext"> m4_include([m4/guile.m4])</span>
<span id="LC9" class="line" lang="plaintext"> m4_include([m4/hooks.m4])</span>
<span id="LC10" class="line" lang="plaintext"> m4_include([m4/host-cpu-c-abi.m4])</span>
<span id="LC11" class="line" lang="plaintext">[...]</span></code></pre>
<copy-code></copy-code>
</div>
<p dir="auto">As per the <code>configure.ac</code> extract quoted above, the presence of the option is "automagic" based on whether <code>gtk-doc</code> (or at least <code>gtk-doc-am</code>) is installed on the system used to produce the release tarball (<code>make dist</code>).</p>
<p dir="auto">I suspect what happened is <a href="https://gitlab.com/ZoltanFridrich" data-user="8380993" data-reference-type="user" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Zoltán Fridrich">@ZoltanFridrich</a> didn't have <code>gtk-doc</code> installed in the environment used to generate the 3.7.4 release.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1341">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/258693562fe188c68fe23b7fef6e696d/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1341"}}</script>
</p>
</div>
</body>
</html>