<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1562#note_893869026">commented</a>:
</p>
<div class="md" style="">
<p dir="auto">I have been thinking about this for a while and here are a couple of observations: firstly, until now we stored the <code>.hmac</code> file as <code>/usr/lib64/.lib<name>.so.*.hmac</code> etc., where it was obvious that the <code>.hmac</code> file corresponds to <code>/usr/lib64/lib<name>.so.*</code>. Now, in the new format, this information (mapping between <code>.hmac</code> files and actual library files) is missing. I suggest either extending the format like:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-ini" lang="ini" v-pre="true" style="border-radius: 2px; margin: 0 0 8px; padding: 8px 12px; border: 1px solid #dbdbdb;"><code><span id="LC1" class="line" lang="ini"><span class="nn">[global]</span></span>
<span id="LC2" class="line" lang="ini"><span class="err">...</span></span>
<span id="LC3" class="line" lang="ini"></span>
<span id="LC4" class="line" lang="ini"><span class="nn">[libgnutls.so.30]</span></span>
<span id="LC5" class="line" lang="ini"><span class="py">path</span> <span class="p">=</span> <span class="s">...</span></span>
<span id="LC6" class="line" lang="ini"><span class="py">hmac</span> <span class="p">=</span> <span class="s">...</span></span>
<span id="LC7" class="line" lang="ini"></span>
<span id="LC8" class="line" lang="ini"><span class="nn">[libnettle.so.8]</span></span>
<span id="LC9" class="line" lang="ini"><span class="py">path</span> <span class="p">=</span> <span class="s">...</span></span>
<span id="LC10" class="line" lang="ini"><span class="py">hmac</span> <span class="p">=</span> <span class="s">...</span></span>
<span id="LC11" class="line" lang="ini"></span>
<span id="LC12" class="line" lang="ini"><span class="err">...</span></span></code></pre>
<copy-code></copy-code>
</div>
<p dir="auto">Note the section names are library SONAMEs.</p>
<p dir="auto">Secondly, instead of determining the library paths at <code>configure</code> time, <code>fipshmac</code> could resolve them at run time. That could be done either by taking the path to <code>libgnutls.so.*</code> only or taking SONAMEs instead of file paths, something like:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-make" lang="make" v-pre="true" style="border-radius: 2px; margin: 0 0 8px; padding: 8px 12px; border: 1px solid #dbdbdb;"><code><span id="LC1" class="line" lang="make"><span class="err">lib/fipshmac</span> <span class="err">$(gnutls_so)</span> <span class="err">$(nettle_so)</span> <span class="err">$(hogweed_so)</span> <span class="err">$(gmp_so)</span></span></code></pre>
<copy-code></copy-code>
</div>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1562#note_893869026">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/-/sent_notifications/799f97520cf63992bfb9f84082936cbc/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1562#note_893869026"}}</script>
</p>
</div>
</body>
</html>