<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Noto Sans", Ubuntu, Cantarell, "Helvetica Neue", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Noto Sans", Ubuntu, Cantarell, "Helvetica Neue", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";'>
<div class="content">
<p class="details" style="font-style: italic; color: #666;">
<a href="https://gitlab.com/jas">Simon Josefsson</a> created an issue: <a href="https://gitlab.com/gnutls/gnutls/-/issues/1419">#1419</a>
</p>
<div class="md" style="color: #303030; word-wrap: break-word;">
<p dir="auto" style="color: #303030; margin: 0 0 16px;" align="initial">GnuTLS code is generally indented well, but this is not enforced and there is a lot of newly added code that is indented differently. Having a consistent indentation style helps readability and thus maintainability, in my opinion. Gnulib's maint.mk has rules for both running 'indent' (make indent) and for checking that code is indented (make syntax-check).</p>
<p dir="auto" style="color: #303030; margin: 0 0 16px;" align="initial">What do you think about indenting the code, and enabling 'make syntax-check' to check for this? Preferably shortly after the 3.8.0 release, I would suggest.</p>
<p dir="auto" style="color: #303030; margin: 0 0 16px;" align="initial">I can prepare a merge request for this, but only if there is agreement that this is a good idea, and also decision on timing when to do it because it affects a lot of files and it will cause conflicts with other merge requests.</p>
<p dir="auto" style="color: #303030; margin: 0 0 16px;" align="initial">The CONTRIBUTING file says to use 'indent -linux', so I suppose this is the style we should mandate? I prefer regular GNU-style indent though, but would not want to suggest changing anything in this area now.</p>
<p dir="auto" style="color: #303030; margin: 0;" align="initial">GnuTLS would have to update to modern gnulib first, though, but this is covered by (stale?) MR <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1509" data-reference-type="merge_request" data-original="!1509" data-link="false" data-link-reference="false" data-project="179611" data-merge-request="134570857" data-project-path="gnutls/gnutls" data-iid="1509" data-container="body" data-placement="top" title="gnulib: update git submodule" class="gfm gfm-merge_request" style="margin-top: 0;">!1509</a>.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1419">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/a0f81abe43822b1f7dfe3ea0cc5c20d6/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1419"}}</script>
</p>
</div>
</body>
</html>