<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Noto Sans", Ubuntu, Cantarell, "Helvetica Neue", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Noto Sans", Ubuntu, Cantarell, "Helvetica Neue", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/jas">Simon Josefsson</a>
<a href="https://gitlab.com/gnutls/gnutls/-/issues/1419#note_1161957218">commented</a>:
</p>
<div class="md" style="color: #303030; word-wrap: break-word;">
<p dir="auto" style="color: #303030; margin: 0 0 16px;" align="initial">For libidn2 I'm using stages 'quick', 'build' (bootstrap), and 'test' (tarball) that includes 'make syntax-check' which checks indentation -- see output <a href="https://gitlab.com/libidn/libidn2/-/pipelines/682199532" style="margin-top: 0;">https://gitlab.com/libidn/libidn2/-/pipelines/682199532</a> -- the 'quick' test is supposed to be one non-parallel work to check as much as possible before starting all the other builds. However my experience with this is that I'm not sure it is worth it -- it adds complexity. I think it is better to not use stages for this -- but instead put all bootstrap-jobs in one stage, which would depend on a single bootstrap-job that does syntax checking. This has the same advantages (saving CPU cycles) with less complexity. I'm working on a generalized CI/CD rule for all projects I'm working on (libidn, libidn2, gsasl, libgssglue, libntlm, libtasn1, shishi, gss, ...) right now and will try that approach for it.</p>
<p dir="auto" style="color: #303030; margin: 0;" align="initial">I haven't used pre-commit's recently, do they run on the developer's laptop? My experience with those mechanisms is that they are more fragile and harder to maintain than keeping CI/CD operational (which normally is at least rather reproducible and with public logs). And when pre-commit tasks start to consume CPU time, developers are rightly annoyed because it gets in the way of work. The 'make syntax-check' approach is quite nice IMHO, but it does require a ./bootstrap run which is sometimes expensive. Hmm. Gnulib does ship a 'GNUmakefile' which will work without bootstrapping. How about seeing if we can use it do a 'make quick-syntax-check' rule that doesn't require bootstrapping?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1419#note_1161957218">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/310f26573404eef4d161fe15cfe11b81/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1419#note_1161957218"}}</script>
</p>
</div>
</body>
</html>