<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Noto Sans", Ubuntu, Cantarell, "Helvetica Neue", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Noto Sans", Ubuntu, Cantarell, "Helvetica Neue", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1622#note_1185532049">discussion</a>:
</p>
<div class="md" style="color: #333238; word-wrap: break-word;">
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">Sorry, I thought that you were still working on that change (as the CI has some error). Yes, I agree that it would be nice header-only is default.</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">Regarding this <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1622/diffs?commit_id=fd907d08893db6e0fa9bd968296f6dbc2b96e192" data-reference-type="merge_request" data-original="commit" data-link="true" data-link-reference="true" data-project="179611" data-merge-request="168885268" data-project-path="gnutls/gnutls" data-iid="1622" data-container="body" data-placement="top" title="gnutlsxx: become header-only library" class="gfm gfm-merge_request" style="margin-top: 0;">commit</a>, I would suggest adding stubs only for public symbols. For that, it might be easier to organize the change like:</p>
<div class="gl-relative markdown-code-block js-markdown-code" style="margin-bottom: 0;">
<pre lang="c" class="code highlight js-syntax-highlight language-c" v-pre="true" style='display: block; font-size: 13px; color: #333238; line-height: 1.6em; overflow-x: auto; border-radius: 4px; position: relative; font-family: "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: 4px; white-space: pre; margin-top: 0; font-family: "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="c" style="margin-top: 0;"><span class="cp" style="margin-top: 0;">#ifdef ENABLE_SRP</span></span>
<span id="LC2" class="line" lang="c"></span>
<span id="LC3" class="line" lang="c"><span class="kt" style="margin-top: 0;">void</span></span>
<span id="LC4" class="line" lang="c"><span class="nf" style="margin-top: 0;">gnutls_srp_set_client_credentials_function</span><span class="p">(</span><span class="n">gnutls_srp_client_credentials_t</span></span>
<span id="LC5" class="line" lang="c"> <span class="n" style="margin-top: 0;">cred</span><span class="p">,</span></span>
<span id="LC6" class="line" lang="c"> <span class="n" style="margin-top: 0;">gnutls_srp_client_credentials_function</span></span>
<span id="LC7" class="line" lang="c"> <span class="o" style="margin-top: 0;">*</span> <span class="n">func</span><span class="p">)</span></span>
<span id="LC8" class="line" lang="c"><span class="p" style="margin-top: 0;">{</span></span>
<span id="LC9" class="line" lang="c"> <span class="cm" style="margin-top: 0;">/* proper implementation of this API function */</span></span>
<span id="LC10" class="line" lang="c"><span class="p" style="margin-top: 0;">}</span></span>
<span id="LC11" class="line" lang="c"></span>
<span id="LC12" class="line" lang="c"><span class="k" style="margin-top: 0;">const</span> <span class="kt">char</span> <span class="o">*</span><span class="nf">gnutls_srp_server_get_username</span><span class="p">(</span><span class="n">gnutls_session_t</span> <span class="n">session</span><span class="p">)</span></span>
<span id="LC13" class="line" lang="c"><span class="p" style="margin-top: 0;">{</span></span>
<span id="LC14" class="line" lang="c"> <span class="cm" style="margin-top: 0;">/* proper implementation of this API function */</span></span>
<span id="LC15" class="line" lang="c"><span class="p" style="margin-top: 0;">}</span></span>
<span id="LC16" class="line" lang="c"><span class="p" style="margin-top: 0;">...</span></span>
<span id="LC17" class="line" lang="c"><span class="cp" style="margin-top: 0;">#else</span></span>
<span id="LC18" class="line" lang="c"><span class="kt" style="margin-top: 0;">void</span></span>
<span id="LC19" class="line" lang="c"><span class="nf" style="margin-top: 0;">gnutls_srp_set_client_credentials_function</span><span class="p">(</span><span class="n">gnutls_srp_client_credentials_t</span></span>
<span id="LC20" class="line" lang="c"> <span class="n" style="margin-top: 0;">cred</span><span class="p">,</span></span>
<span id="LC21" class="line" lang="c"> <span class="n" style="margin-top: 0;">gnutls_srp_client_credentials_function</span></span>
<span id="LC22" class="line" lang="c"> <span class="o" style="margin-top: 0;">*</span> <span class="n">func</span><span class="p">)</span></span>
<span id="LC23" class="line" lang="c"><span class="p" style="margin-top: 0;">{</span></span>
<span id="LC24" class="line" lang="c"> <span class="cm" style="margin-top: 0;">/* stub, do nothing */</span></span>
<span id="LC25" class="line" lang="c"><span class="p" style="margin-top: 0;">}</span></span>
<span id="LC26" class="line" lang="c"></span>
<span id="LC27" class="line" lang="c"><span class="k" style="margin-top: 0;">const</span> <span class="kt">char</span> <span class="o">*</span><span class="nf">gnutls_srp_server_get_username</span><span class="p">(</span><span class="n">gnutls_session_t</span> <span class="n">session</span><span class="p">)</span></span>
<span id="LC28" class="line" lang="c"><span class="p" style="margin-top: 0;">{</span></span>
<span id="LC29" class="line" lang="c"> <span class="cm" style="margin-top: 0;">/* stub, do nothing but returning NULL */</span></span>
<span id="LC30" class="line" lang="c"><span class="p" style="margin-top: 0;">}</span></span>
<span id="LC31" class="line" lang="c"><span class="p" style="margin-top: 0;">...</span></span>
<span id="LC32" class="line" lang="c"><span class="cp" style="margin-top: 0;">#endif</span></span></code></pre>
<copy-code></copy-code>
</div>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1622#note_1185532049">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/cb4380a5448801e75d9598ba54b010e3/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1622#note_1185532049"}}</script>
</p>
</div>
</body>
</html>