<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "Menlo"), DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, -apple-system),BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; font-family: var(--default-regular-font, -apple-system),BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1678#note_1216750210">commented</a>:
</p>
<div class="md" style="color: #333238; word-wrap: break-word;">
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">as of <a href="https://gitlab.com/gnutls/gnutls/-/commit/d78beb5d57d36508e2a5fe2c4e046e46c9c4d149" data-reference-type="commit" data-original="d78beb5d" data-link="false" data-link-reference="false" data-project="179611" data-commit="d78beb5d57d36508e2a5fe2c4e046e46c9c4d149" data-container="body" data-placement="top" title="Forbid unsolicited CompressedCertificate message" class="gfm gfm-commit has-tooltip" style='font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; font-size: 95%; margin-top: 0;'>d78beb5d</a> it looks much better. Unsolicited compressed certs result in alerts, and I think now it's just the alerts that might need tweaking:</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">No compression algorithms enabled, sending compressed certificates results in "decode error", I've expected "unexpected_message" (based on my interpretation of the generic rule of <a href="https://datatracker.ietf.org/doc/html/rfc8446#section-4" rel="nofollow noreferrer noopener" target="_blank" style="margin-top: 0;">https://datatracker.ietf.org/doc/html/rfc8446#section-4</a>).</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Some compression algorithms enabled, sending certificates compressed with an unsupported algorithm results in "illegal_parameter", I've expected "bad_certificate" (not super confident about that one. I've based my understanding on <a href="https://datatracker.ietf.org/doc/html/rfc8879#section-4-7" rel="nofollow noreferrer noopener" target="_blank" style="margin-top: 0;">https://datatracker.ietf.org/doc/html/rfc8879#section-4-7</a>, will happily stand corrected if there's some other rule applicable here).</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1678#note_1216750210">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/59cdd7affc52a81e1daf1f99680f8a78/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1678#note_1216750210"}}</script>
</p>
</div>
</body>
</html>