<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "Menlo"), DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, -apple-system),BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; font-family: var(--default-regular-font, -apple-system),BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1677#note_1217485847">commented</a>:
</p>
<div class="md" style="color: #333238; word-wrap: break-word;">
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">Code LGTM, limited manual testing found no problems -> approving.</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 16px; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">TLS 1.2, sending a CCS with 0x02 for a value triggers the newly added assert:</li>
</ul>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre lang="plaintext" class="code highlight js-syntax-highlight language-plaintext" data-canonical-lang="" v-pre="true" style='display: block; font-size: 0.875rem; color: #333238; line-height: 1.6em; overflow-x: auto; border-radius: 4px; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: 0.875rem; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: 4px; white-space: pre; margin-top: 0; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">|<5>| REC[0x213b560]: Expected Packet ChangeCipherSpec(20)</span>
<span id="LC2" class="line" lang="plaintext">|<5>| REC[0x213b560]: Received Packet ChangeCipherSpec(20) with length: 1</span>
<span id="LC3" class="line" lang="plaintext">|<5>| REC[0x213b560]: Decrypted Packet[2] ChangeCipherSpec(20) with length: 1</span>
<span id="LC4" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/record.c[record_add_to_buffers]:863</span>
<span id="LC5" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/record.c[_gnutls_recv_in_buffers]:1606</span>
<span id="LC6" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/record.c[_gnutls_recv_int]:1804</span>
<span id="LC7" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/handshake.c[recv_handshake_final]:3438</span>
<span id="LC8" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/handshake.c[handshake_server]:3641</span>
<span id="LC9" class="line" lang="plaintext">Error in handshake: An unexpected TLS packet was received.</span></code></pre>
<copy-code></copy-code>
</div>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 16px; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">TLS 1.2, sending a CCS with 0x0101 for a value triggers the newly added assert:</li>
</ul>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre lang="plaintext" class="code highlight js-syntax-highlight language-plaintext" data-canonical-lang="" v-pre="true" style='display: block; font-size: 0.875rem; color: #333238; line-height: 1.6em; overflow-x: auto; border-radius: 4px; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: 0.875rem; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: 4px; white-space: pre; margin-top: 0; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">|<5>| REC[0xf8d060]: Expected Packet ChangeCipherSpec(20)</span>
<span id="LC2" class="line" lang="plaintext">|<5>| REC[0xf8d060]: Received Packet ChangeCipherSpec(20) with length: 2</span>
<span id="LC3" class="line" lang="plaintext">|<5>| REC[0xf8d060]: Decrypted Packet[2] ChangeCipherSpec(20) with length: 2</span>
<span id="LC4" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/record.c[record_add_to_buffers]:863</span>
<span id="LC5" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/record.c[_gnutls_recv_in_buffers]:1606</span>
<span id="LC6" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/record.c[_gnutls_recv_int]:1804</span>
<span id="LC7" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/handshake.c[recv_handshake_final]:3438</span>
<span id="LC8" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/handshake.c[handshake_server]:3641</span>
<span id="LC9" class="line" lang="plaintext">Error in handshake: An unexpected TLS packet was received.</span>
<span id="LC10" class="line" lang="plaintext">|<5>| REC: Sending Alert[2|10] - Unexpected message</span></code></pre>
<copy-code></copy-code>
</div>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 16px; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">TLS 1.3, sending a CCS after Finished still results in unexpected_message:</li>
</ul>
<div class="gl-relative markdown-code-block js-markdown-code" style="margin-bottom: 0;">
<pre lang="plaintext" class="code highlight js-syntax-highlight language-plaintext" data-canonical-lang="" v-pre="true" style='display: block; font-size: 0.875rem; color: #333238; line-height: 1.6em; overflow-x: auto; border-radius: 4px; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: 0.875rem; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: 4px; white-space: pre; margin-top: 0; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">|<5>| REC[0xf8d060]: Expected Packet Application Data(23)</span>
<span id="LC2" class="line" lang="plaintext">|<5>| REC[0xf8d060]: Received Packet ChangeCipherSpec(20) with length: 1</span>
<span id="LC3" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/record.c[_gnutls_recv_in_buffers]:1378</span>
<span id="LC4" class="line" lang="plaintext">|<3>| ASSERT: ../../lib/record.c[_gnutls_recv_int]:1804</span>
<span id="LC5" class="line" lang="plaintext">Error while receiving data</span>
<span id="LC6" class="line" lang="plaintext">|<5>| REC: Sending Alert[2|10] - Unexpected message</span>
<span id="LC7" class="line" lang="plaintext">|<5>| REC[0xf8d060]: Preparing Packet Alert(21) with length: 2 and min pad: 0</span>
<span id="LC8" class="line" lang="plaintext">|<9>| ENC[0xf8d060]: cipher: AES-128-GCM, MAC: AEAD, Epoch: 2</span>
<span id="LC9" class="line" lang="plaintext">|<5>| REC[0xf8d060]: Sent Packet[3] Alert(21) in epoch 2 and length: 24</span>
<span id="LC10" class="line" lang="plaintext">Error: An unexpected TLS packet was received</span></code></pre>
<copy-code></copy-code>
</div>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1677#note_1217485847">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/be05256682e175457d7aa67579943393/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1677#note_1217485847"}}</script>
</p>
</div>
</body>
</html>