<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "Menlo"), DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, -apple-system),BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; font-family: var(--default-regular-font, -apple-system),BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/ametzler">Andreas Metzler</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1716#note_1293909529">commented</a>:
</p>
<div class="md" style="color: #333238; word-wrap: break-word;">
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">I just realized that I had accidentally already removed SKIP_DATEFUDGE_CHECK without pre-discussing.</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">Afaict the current code <a href="https://gitlab.com/ametzler/gnutls/-/blob/master/tests/scripts/common.sh#L101" style="margin-top: 0;">https://gitlab.com/ametzler/gnutls/-/blob/master/tests/scripts/common.sh#L101</a> does not seem to be really useful:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre lang="shell" class="code highlight js-syntax-highlight language-shell" data-canonical-lang="sh" v-pre="true" style='display: block; font-size: 0.875rem; color: #333238; line-height: 1.6em; overflow-x: auto; border-radius: 4px; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: 0.875rem; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: 4px; white-space: pre; margin-top: 0; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="shell" style="margin-top: 0;">check_for_datefudge<span class="o" style="margin-top: 0;">()</span> <span class="o">{</span></span>
<span id="LC2" class="line" lang="shell"> <span class="c" style="margin-top: 0;"># On certain platforms running datefudge date fails (e.g., x86 datefudge</span></span>
<span id="LC3" class="line" lang="shell"> <span class="c" style="margin-top: 0;"># with x86-64 date app).</span></span>
<span id="LC4" class="line" lang="shell"> <span class="k" style="margin-top: 0;">if </span><span class="nb">test</span> <span class="s2">"</span><span class="k">${</span><span class="nv">SKIP_DATEFUDGE_CHECK</span><span class="k">}</span><span class="s2">"</span> <span class="o">=</span> 1<span class="p">;</span><span class="k">then</span></span>
<span id="LC5" class="line" lang="shell"><span class="k" style="margin-top: 0;"> return</span></span>
<span id="LC6" class="line" lang="shell"><span class="k" style="margin-top: 0;"> fi</span></span>
<span id="LC7" class="line" lang="shell"></span>
<span id="LC8" class="line" lang="shell"><span class="k" style="margin-top: 0;"> </span><span class="nv">TSTAMP</span><span class="o">=</span><span class="sb">`</span>datefudge <span class="nt">-s</span> <span class="s2">"2006-09-23"</span> <span class="s2">"</span><span class="k">${</span><span class="nv">top_builddir</span><span class="k">}</span><span class="s2">/tests/datefudge-check"</span> <span class="o">||</span> <span class="nb">true</span><span class="sb">`</span></span>
<span id="LC9" class="line" lang="shell"> <span class="k" style="margin-top: 0;">if </span><span class="nb">test</span> <span class="s2">"</span><span class="nv">$TSTAMP</span><span class="s2">"</span> <span class="o">!=</span> <span class="s2">"1158969600"</span> <span class="o">||</span> <span class="nb">test</span> <span class="s2">"</span><span class="nv">$WINDOWS</span><span class="s2">"</span> <span class="o">=</span> 1<span class="p">;</span> <span class="k">then</span></span>
<span id="LC10" class="line" lang="shell"><span class="k" style="margin-top: 0;"> return </span>1</span>
<span id="LC11" class="line" lang="shell"> <span class="k" style="margin-top: 0;">fi</span></span>
<span id="LC12" class="line" lang="shell"><span class="o" style="margin-top: 0;">}</span></span>
<span id="LC13" class="line" lang="shell"></span></code></pre>
<copy-code></copy-code>
</div>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">It overrides checking whether datefudge works with "yes it does". I could understand the need for "do not even try to test, it is broken, just act as if it was absent", but not for "do not test whether it works but use it anyway".</p>
<p dir="auto" style="color: #333238; margin: 0;" align="initial">Also it does not seem to be used by the current CI.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1716#note_1293909529">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/0120648f075b79cc794fe532f77d8e4b/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1716#note_1293909529"}}</script>
</p>
</div>
</body>
</html>