<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/ametzler">Andreas Metzler</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1754#note_1462662293">discussion</a>:
</p>
<div class="md" style="color: #333238; word-wrap: break-word;">
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">Daiki Ueno <a href="https://gitlab.com/dueno" data-reference-type="user" data-user="470892" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Daiki Ueno" style="background-color: #cbe2f9; border-radius: 4px; color: #0b5cad; margin-top: 0; padding: 0 2px;">@dueno</a> wrote</p>
<blockquote dir="auto" style="font-size: inherit; color: #535158; padding-top: 0.5rem; padding-bottom: 0.5rem; padding-left: 1.5rem; box-shadow: inset 4px 0 0 0 #dcdcde; border-top-width: 0; border-bottom-width: 0; border-right-width: 0; margin: 0.5rem 0;" align="initial">
<p style="color: inherit; line-height: 1.5; margin: 0;">Yeah, I see the similar issue even with datefudge with the current git master, with make check TESTS=TESTS=ocsp-tests/ocsp-must-staple-connection.sh. Then pgrep gnutls-serv reports 10 processes are still running.</p>
</blockquote>
<blockquote dir="auto" style="font-size: inherit; color: #535158; padding-top: 0.5rem; padding-bottom: 0.5rem; padding-left: 1.5rem; box-shadow: inset 4px 0 0 0 #dcdcde; border-top-width: 0; border-bottom-width: 0; border-right-width: 0; margin: 0.5rem 0;" align="initial">
<p style="color: inherit; line-height: 1.5; margin: 0;">In this MR, I changed to call the datefudge command line with exec, but it might not work with faketime.</p>
</blockquote>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">tests/ocsp-tests/ocsp-must-staple-connection.sh in this changed version aborts during "Test 5: Server with valid certificate - expired staple", code after
<a href="https://gitlab.com/dueno/gnutls/-/blob/wip/dueno/faketime/tests/ocsp-tests/ocsp-must-staple-connection.sh#L311" style="margin-top: 0;">https://gitlab.com/dueno/gnutls/-/blob/wip/dueno/faketime/tests/ocsp-tests/ocsp-must-staple-connection.sh#L311</a></p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre data-canonical-lang="sh" class="code highlight js-syntax-highlight language-shell" lang="shell" v-pre="true" style='display: block; font-size: 14px; color: #333238; line-height: 1.6em; overflow-x: auto; border-radius: 4px; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: 0.875rem; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: 4px; white-space: pre; margin-top: 0; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="shell" style="margin-top: 0;">gnutls_timewrapper_standalone static <span class="s2" style="margin-top: 0;">"</span><span class="k">${</span><span class="nv">EXP_OCSP_DATE</span><span class="k">}</span><span class="s2">"</span> <span class="se">\</span></span>
<span id="LC2" class="line" lang="shell"> <span class="k" style="margin-top: 0;">${</span><span class="nv">OPENSSL</span><span class="k">}</span> ocsp <span class="nt">-index</span> <span class="s2">"</span><span class="k">${</span><span class="nv">INDEXFILE</span><span class="k">}</span><span class="s2">"</span> <span class="nt">-rsigner</span> <span class="s2">"</span><span class="k">${</span><span class="nv">srcdir</span><span class="k">}</span><span class="s2">/ocsp-tests/certs/ocsp-server.pem"</span> <span class="nt">-rkey</span> <span class="s2">"</span><span class="k">${</span><span class="nv">srcdir</span><span class="k">}</span><span class="s2">/ocsp-tests/certs/ocsp-server.key"</span> <span class="nt">-CA</span> <span class="s2">"</span><span class="k">${</span><span class="nv">srcdir</span><span class="k">}</span><span class="s2">/ocsp-tests/certs/ca.pem"</span> <span class="nt">-reqin</span> <span class="s2">"</span><span class="k">${</span><span class="nv">OCSP_REQ_FILE</span><span class="k">}</span><span class="s2">"</span> <span class="nt">-respout</span> <span class="s2">"</span><span class="k">${</span><span class="nv">OCSP_RESPONSE_FILE</span><span class="k">}</span><span class="s2">"</span> <span class="nt">-ndays</span> 2 </span></code></pre>
<copy-code></copy-code>
</div>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">is not executed. Afaui at this point the shell execs datefudge, replacing tests/ocsp-tests/ocsp-must-staple-connection.sh (and wrongly returns SUCCESS).</p>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">At this point I am fairly convinced we need to either use a wrapper script or</p>
<ol dir="auto" style="text-align: initial; margin: 0; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">instead of defining FAKETIME_F have FAKETIME_F_OPT (as either "-s" or "-f"),</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">completely dropping gnutls_timewrapper_standalone() and</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">having the actual test scipts run <code style='font-size: 0.875rem; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: 4px; margin-top: 0; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>$FAKETIME</code> (instead of <code style='font-size: 0.875rem; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: 4px; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>gnutls_timewrapper_standalone</code>) and <code style='font-size: 0.875rem; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: 4px; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>$FAKETIME ${FAKETIME_F_OPT}</code> (instead of <code style='font-size: 0.875rem; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: 4px; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>gnutls_timewrapper_standalone static</code>)</li>
</ol>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1754#note_1462662293">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/18defeea1b77f293d7e7fdd4294d7fb8/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1754#note_1462662293"}}</script>
</p>
</div>
</body>
</html>