<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/ametzler">Andreas Metzler</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1838#note_1911979910">discussion</a>:
</p>
<div class="md" style="color: #333238; word-wrap: break-word;">
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">Elliott Mitchell commented on a discussion: <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1838#note_1911798699" data-reference-type="merge_request" data-original="https://gitlab.com/gnutls/gnutls/-/merge_requests/1838#note_1911798699" data-link="false" data-link-reference="true" data-project="179611" data-merge-request="302730719" data-project-path="gnutls/gnutls" data-iid="1838" data-container="body" data-placement="top" title="server_name: synchronize server name send/receive (remove dns check)" class="gfm gfm-merge_request" style="margin-top: 0;">!1838 (comment 1911798699)</a></p>
<blockquote dir="auto" style="font-size: inherit; color: #535158; padding-top: .5rem; padding-bottom: .5rem; padding-left: 1.5rem; --tw-shadow: inset 4px 0 0 0 var(--gray-100, #dcdcde); --tw-shadow-colored: inset 4px 0 0 0 var(--tw-shadow-color); box-shadow: var(--tw-ring-offset-shadow, 0 0 #0000), var(--tw-ring-shadow, 0 0 #0000), var(--tw-shadow); border-top-width: 0; border-bottom-width: 0; border-right-width: 0; margin: .5rem 0;" align="initial">
<p style="color: inherit; line-height: 1.5; margin: 0;">There are actually 2 distinct issues here. First, <code style='font-size: 90%; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-weight: inherit; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>_gnutls_dnsname_is_valid()</code> is rather inconsistent in what it accepts.</p>
</blockquote>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">[...]</p>
<blockquote dir="auto" style="font-size: inherit; color: #535158; padding-top: .5rem; padding-bottom: .5rem; padding-left: 1.5rem; --tw-shadow: inset 4px 0 0 0 var(--gray-100, #dcdcde); --tw-shadow-colored: inset 4px 0 0 0 var(--tw-shadow-color); box-shadow: var(--tw-ring-offset-shadow, 0 0 #0000), var(--tw-ring-shadow, 0 0 #0000), var(--tw-shadow); border-top-width: 0; border-bottom-width: 0; border-right-width: 0; margin: .5rem 0;" align="initial">
<p style="color: inherit; line-height: 1.5; margin: 0;">The other issue is testing is <strong style="font-weight: 600; margin-top: 0;">only</strong> being done in <code style='font-size: 90%; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>_gnutls_server_name_recv_params()</code> and not <code style='font-size: 90%; color: #1f1e24; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; font-weight: inherit; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>_gnutls_server_name_send_params()</code>. The result is GnuTLS is being liberal in what it sends, conservative in what it accepts. This is how you destroy interoperability.
[...]</p>
</blockquote>
<p dir="auto" style="color: #333238; margin: 0 0 16px;" align="initial">Yessish. However you proposed to solve both issues by "dropping the checking". My question was whether this was the correct solution.</p>
<p dir="auto" style="color: #333238; margin: 0;" align="initial">To my eyes nowadays decreasing enforcement of RFC-compliance on the server side seems quite strange. Usually nowadays one tries to decrease complexity and attack surface.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1838#note_1911979910">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/15d2174bd946a046e83152d6f560f8af/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1838#note_1911979910"}}</script>
</p>
</div>
</body>
</html>