<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p class="details" style="font-style: italic; color: #737278;">
<a href="https://gitlab.com/leeriorio">Ekaterina Zilotina</a> created an issue: <a href="https://gitlab.com/gnutls/gnutls/-/issues/1573">#1573</a>
</p>
<div class="md" style="position: relative; z-index: 1; color: #28272d; word-wrap: break-word;">
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">In result of static analyse of gnutls source code I found error with "memory leak" category there:</p>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">file <strong style="font-weight: 600; margin-top: 0;">certtool-cfg.c</strong> in lines <a href="https://gitlab.com/gnutls/gnutls/-/blob/master/src/certtool-cfg.c#L623">623</a>, <a href="https://gitlab.com/gnutls/gnutls/-/blob/master/src/certtool-cfg.c#L649">649</a> and <a href="https://gitlab.com/gnutls/gnutls/-/blob/master/src/certtool-cfg.c#L791">791</a> contains calls of <strong style="font-weight: 600;"><code style='font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>getline()</code></strong>. Of course, there are checks of return values there which loks like that:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style='display: block; font-size: 14px; color: #28272d; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">char *lineptr = NULL;</span>
<span id="LC2" class="line" lang="plaintext">size_t linesize = 0;</span>
<span id="LC3" class="line" lang="plaintext"> ...</span>
<span id="LC4" class="line" lang="plaintext">ret = getline(&lineptr, &linesize, stdin);</span>
<span id="LC5" class="line" lang="plaintext">if (ret == -1)</span>
<span id="LC6" class="line" lang="plaintext"> return ...;</span></code></pre>
<copy-code></copy-code>
</div>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">But <a href="https://pubs.opengroup.org/onlinepubs/9799919799/functions/getline.html#:~:text=If%20*lineptr%20is,the%20new%20size." rel="nofollow noreferrer noopener" target="_blank" style="margin-top: 0;">docs says</a> that when we using <strong style="font-weight: 600;"><code style='font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>getline()</code></strong> with lineptr==NULL and linesize==0 the memory will be allocated. In case when <a href="https://gitlab.com/libidn/gnulib-mirror/-/blob/bd1e981434c98751b1106a1744e77a27317b52b3/lib/getdelim.c#L63">getdelim()</a> returns whith negative value (error means) we just exit with no memory clearing. By this I have a question: how about to add <strong style="font-weight: 600;"><code style='font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>free(lineptr)</code></strong> in blocks of <strong style="font-weight: 600;"><code style='font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>ret</code></strong> checking after getline call?</p>
<p dir="auto" style="color: #28272d; margin: 0;" align="initial">There are similar call in file <a href="https://gitlab.com/gnutls/gnutls/-/blob/master/src/cli.c#L1920" style="margin-top: 0;"><strong style="font-weight: 600; margin-top: 0;">cli.c</strong></a></p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1573">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/e332b8226d36e56c0ebee32519ebae70/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1573"}}</script>
</p>
</div>
</body>
</html>