<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/dueno">Daiki Ueno</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/-/issues/1573#note_2060720816">discussion</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #28272d; word-wrap: break-word;">
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">The general workflow to create a merge-request can be found in the GitLab documentation: <a href="https://docs.gitlab.com/ee/user/project/merge_requests/creating_merge_requests.html" rel="nofollow noreferrer noopener" target="_blank" style="margin-top: 0;">https://docs.gitlab.com/ee/user/project/merge_requests/creating_merge_requests.html</a></p>
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial">There is also a GnuTLS specific contribution guide in the repository: <a href="https://gitlab.com/gnutls/gnutls/-/blob/master/CONTRIBUTING.md?ref_type=heads" style="margin-top: 0;">https://gitlab.com/gnutls/gnutls/-/blob/master/CONTRIBUTING.md?ref_type=heads</a></p>
<blockquote dir="auto" style="font-size: inherit; color: #4c4b51; padding-top: .5rem; padding-bottom: .5rem; padding-left: 1.5rem; --tw-shadow: inset 4px 0 0 0 var(--gray-100, #dcdcde); --tw-shadow-colored: inset 4px 0 0 0 var(--tw-shadow-color); box-shadow: 0 0 #0000, 0 0 #0000, var(--tw-shadow); border-top-width: 0; border-bottom-width: 0; border-right-width: 0; margin: .5rem 0;" align="initial">
<p style="color: inherit; line-height: 1.5; margin: 0;">P.S. In addition for memory leaks theme: there is potential descriptor leak <a href="https://gitlab.com/gnutls/gnutls/-/blob/master/lib/x509/verify-high2.c#L391" style="margin-top: 0;">there</a> in analogy when we <a href="https://gitlab.com/gnutls/gnutls/-/blob/master/lib/x509/verify-high2.c#L398">fast-end return</a> (without <strong style="font-weight: 600;"><code style='font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 2px 4px;'>closedir()</code></strong> calling). I think these fixes can be committed together (or it needs it's own issue created?)</p>
</blockquote>
<p dir="auto" style="color: #28272d; margin: 0;" align="initial">Good catch; I'd suggest splitting them in separate commits, though it's perfectly fine to include all of them in the same merge-request.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1573#note_2060720816">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/a899aae90bde5b33189e0d99cb0eef3e/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1573#note_2060720816"}}</script>
</p>
</div>
</body>
</html>