<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/ghen2">Geert Hendrickx</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1883#note_2151001954">commented</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #28272d; word-wrap: break-word;">
<p dir="auto" style="color: #28272d; margin: 0 0 16px;" align="initial"><a href="https://gitlab.com/dueno" data-reference-type="user" data-user="470892" data-container="body" data-placement="top" class="gfm gfm-project_member js-user-link" title="Daiki Ueno" style="color: #0b5cad; background-color: #cbe2f9; border-radius: .25rem; margin-top: 0; padding: 0 2px;">@dueno</a> This fixes SECP256R1MLKEM768:</p>
<div class="gl-relative markdown-code-block js-markdown-code">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style='display: block; font-size: 14px; color: #28272d; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 16px; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; vertical-align: bottom; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">--- lib/algorithms/groups.c</span>
<span id="LC2" class="line" lang="plaintext">+++ lib/algorithms/groups.c</span>
<span id="LC3" class="line" lang="plaintext">@@ -37,6 +37,13 @@</span>
<span id="LC4" class="line" lang="plaintext"> .pk = GNUTLS_PK_EXP_KYBER768,</span>
<span id="LC5" class="line" lang="plaintext"> };</span>
<span id="LC6" class="line" lang="plaintext"> </span>
<span id="LC7" class="line" lang="plaintext">+static const gnutls_group_entry_st group_mlkem768 = {</span>
<span id="LC8" class="line" lang="plaintext">+ .name = "MLKEM768",</span>
<span id="LC9" class="line" lang="plaintext">+ .id = GNUTLS_GROUP_INVALID,</span>
<span id="LC10" class="line" lang="plaintext">+ .curve = GNUTLS_ECC_CURVE_INVALID,</span>
<span id="LC11" class="line" lang="plaintext">+ .pk = GNUTLS_PK_MLKEM768,</span>
<span id="LC12" class="line" lang="plaintext">+};</span>
<span id="LC13" class="line" lang="plaintext">+</span>
<span id="LC14" class="line" lang="plaintext"> static const gnutls_group_entry_st group_x25519 = {</span>
<span id="LC15" class="line" lang="plaintext"> .name = "X25519",</span>
<span id="LC16" class="line" lang="plaintext"> .id = GNUTLS_GROUP_X25519,</span>
<span id="LC17" class="line" lang="plaintext">@@ -187,9 +194,9 @@</span>
<span id="LC18" class="line" lang="plaintext"> { .name = "SECP256R1-MLKEM768",</span>
<span id="LC19" class="line" lang="plaintext"> .id = GNUTLS_GROUP_EXP_SECP256R1_MLKEM768,</span>
<span id="LC20" class="line" lang="plaintext"> .curve = GNUTLS_ECC_CURVE_SECP256R1,</span>
<span id="LC21" class="line" lang="plaintext">- .pk = GNUTLS_PK_MLKEM768,</span>
<span id="LC22" class="line" lang="plaintext">+ .pk = GNUTLS_PK_ECDSA,</span>
<span id="LC23" class="line" lang="plaintext"> .tls_id = 0x11EB,</span>
<span id="LC24" class="line" lang="plaintext">- .next = &group_secp256r1 },</span>
<span id="LC25" class="line" lang="plaintext">+ .next = &group_mlkem768 },</span>
<span id="LC26" class="line" lang="plaintext"> { .name = "X25519-MLKEM768",</span>
<span id="LC27" class="line" lang="plaintext"> .id = GNUTLS_GROUP_EXP_X25519_MLKEM768,</span>
<span id="LC28" class="line" lang="plaintext"> .curve = GNUTLS_ECC_CURVE_X25519,</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
<p dir="auto" style="color: #28272d; margin: 0;" align="initial">(tested against OpenSSL/oqs-provider)</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1883#note_2151001954">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/04fcfa4e66b4c156c419542dc46aaf0e/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1883#note_2151001954"}}</script>
</p>
</div>
</body>
</html>