<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/eschwartz">Eli Schwartz</a>
commented on a
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1908#note_2268438284">discussion</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<blockquote dir="auto" style="font-size: inherit; color: #626168; padding-top: 0.5rem; padding-bottom: 0.5rem; padding-left: 1rem; border-left-style: solid; margin: 0 0 0.5rem; border-color: #bfbfc3; border-width: 0 0 0 4px;" align="initial">
<p style="color: inherit; line-height: 1.5; margin: 0 0 1rem;">Tal Regev <a href="https://gitlab.com/tal.regev" style="margin-top: 0;">https://gitlab.com/tal.regev</a> commented on a discussion
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1908#note_2268382047" data-reference-type="merge_request" data-original="https://gitlab.com/gnutls/gnutls/-/merge_requests/1908#note_2268382047" data-link="false" data-link-reference="true" data-merge-request="350798247" data-project="179611" data-project-path="gnutls/gnutls" data-iid="1908" data-container="body" data-placement="top" title="add cmake" class="gfm gfm-merge_request">!1908 (comment 2268382047)</a>:</p>
<p style="color: inherit; line-height: 1.5; margin: 0;">I don't agree it not reviewable. Even this PR is not a renewable (maybe
this the word you wanted to write) and not give a breakthrough to replace
the autoconf build system.</p>
</blockquote>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I'm not sure what you're saying here but I definitely used the word I
intended to use, which is "reviewable" and not "renewable".</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I don't know what a "renewable" MR is, but a reviewable MR is one that can
be reviewed by by maintainers and a prerequisite of that is that there is
something available to review.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">First it explain the problem to other people.</p>
<blockquote dir="auto" style="font-size: inherit; color: #626168; padding-top: 0.5rem; padding-bottom: 0.5rem; padding-left: 1rem; border-left-style: solid; margin: 0.5rem 0; border-color: #bfbfc3; border-width: 0 0 0 4px;" align="initial">
</blockquote>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">It doesn't explain the problem to other people. The only problem I'm aware
of is that:</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0 0 1rem; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">the feature has not been accepted</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">a reliance on gnulib means that porting is inherently challenging as you
need to also port gnulib or stop using gnulib</li>
</ul>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Both are explained sufficiently in the linked issue. Neither are explained
in this MR (using ./configure as part of cmake doesn't demonstrate any
challenge, it simply demonstrates that no attempt was made to implement it).</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Assuming I accept for the sake of argument that this MR explains "the
problem", the purpose of an issue is to explain a problem and the purpose
of an MR is to propose a solution. If all this does is explain a problem
and not propose a solution then why isn't this an issue instead?</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Second, it covered the other option to do it (in one commit or fork).</p>
<blockquote dir="auto" style="font-size: inherit; color: #626168; padding-top: 0.5rem; padding-bottom: 0.5rem; padding-left: 1rem; border-left-style: solid; margin: 0.5rem 0; border-color: #bfbfc3; border-width: 0 0 0 4px;" align="initial">
</blockquote>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">What is "it" that is being done? This doesn't build gnutls.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Third, it not against other new build system like Meson.</p>
<blockquote dir="auto" style="font-size: inherit; color: #626168; padding-top: 0.5rem; padding-bottom: 0.5rem; padding-left: 1rem; border-left-style: solid; margin: 0.5rem 0; border-color: #bfbfc3; border-width: 0 0 0 4px;" align="initial">
</blockquote>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">At no point did I criticize this MR by saying I would rather meson, so I'm
not sure what you are replying to.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Forth, it give other people a tool to start build and continue this work.</p>
<blockquote dir="auto" style="font-size: inherit; color: #626168; padding-top: 0.5rem; padding-bottom: 0.5rem; padding-left: 1rem; border-left-style: solid; margin: 0.5rem 0; border-color: #bfbfc3; border-width: 0 0 0 4px;" align="initial">
</blockquote>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I assert my belief that this doesn't provide anything for people to build
on, because this MR doesn't contain any code to build GnuTLS, just
boilerplate that would take a few minutes to reimplement correctly in a
serious attempt to port the real configuration logic over.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">If you will think why replace autoconf is not doable, you will end up stay</p>
<blockquote dir="auto" style="font-size: inherit; color: #626168; padding-top: 0.5rem; padding-bottom: 0.5rem; padding-left: 1rem; border-left-style: solid; margin: 0.5rem 0; border-color: #bfbfc3; border-width: 0 0 0 4px;" align="initial">
<p style="color: inherit; line-height: 1.5; margin: 0;">with auto conf. But if you really think how you can do it, you will get the
conclusion that it needed to be build system that will grow along side with
autoconf.</p>
</blockquote>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">As I've helped several projects move away from autotools I'm quite aware of
how to do it, and you absolutely do need to keep both of them alongside
each other for a while, but the first step <em style="margin-top: 0;">has</em> to be something that is
actually usable, which this is not. This doesn't even build GnuTLS!</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1908#note_2268438284">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/5fc6652154c0770c5d7bdcfdfbd5359e/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1908#note_2268438284"}}</script>
</p>
</div>
</body>
</html>