<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/eschwartz">Eli Schwartz</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1914#note_2273977377">commented</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I know that I said I like meson better than cmake <gl-emoji title="grinning face with smiling eyes" data-name="smile" data-unicode-version="6.0" style="margin-top: 0;">😄</gl-emoji> but for the record I am consistent about my review beliefs as previously discussed at <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1908#note_2268376645" data-reference-type="merge_request" data-original="https://gitlab.com/gnutls/gnutls/-/merge_requests/1908#note_2268376645" data-link="false" data-link-reference="true" data-merge-request="350798247" data-project="179611" data-project-path="gnutls/gnutls" data-iid="1908" data-container="body" data-placement="top" title="Draft: add cmake" class="gfm gfm-merge_request">!1908 (comment 2268376645)</a></p>
<blockquote dir="auto" style="font-size: inherit; color: #626168; padding-top: 0.5rem; padding-bottom: 0.5rem; padding-left: 1rem; border-left-style: solid; margin: 0.5rem 0; border-color: #bfbfc3; border-width: 0 0 0 4px;" align="initial">
<p style="color: inherit; line-height: 1.5; margin: 0;">One of the reason that I contribute only small changes in this PR, that we can talk about and take it from here, instead to create a big PR that no one eventually will use it. (One of the reason why people will not investigate on the new build system).</p>
</blockquote>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I don't think that's the reason at all. I don't think a 4-line MR that only builds a single source file (and that source file is <em style="margin-top: 0;">gnulib</em> and not even gnutls itself) is a good basis for anything. In fact, I don't think there is enough of substance here to even talk about it.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I don't think such a tiny MR is helpful, nor that it can be merged. Additionally, it still relies on running ./configure to produce config.h, which IMO is a nonstarter.</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">Getting gnulib to build with full configuration probe handling would be a significantly more interesting first step -- which means porting the system checks from gnulib *.m4 files sufficient so that a new build system (meson or cmake) can create the correct config.h all on its own.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/1914#note_2273977377">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/eaca354672dddf16e6fc09d865999a5a/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/1914#note_2273977377"}}</script>
</p>
</div>
</body>
</html>