<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/Dariqq">Dariqq</a>
<a href="https://gitlab.com/gnutls/guile/-/issues/31#note_2373988580">commented</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">The following 29 sign algorithms are missing from the latest gnutls (3.8.9)</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">rsa-sha224
dsa-sha224
dsa-sha256
ecdsa-sha1
ecdsa-sha224
ecdsa-sha256
ecdsa-sha384
ecdsa-sha512
dsa-sha384
dsa-sha512
ecdsa-sha3-224
ecdsa-sha3-256
ecdsa-sha3-384
ecdsa-sha3-512
dsa-sha3-224
dsa-sha3-256
dsa-sha3-384
dsa-sha3-512
rsa-sha3-224
rsa-sha3-256
rsa-sha3-384
rsa-sha3-512
rsa-raw
gost-94
gost-256
gost-512
mldsa44
mldsa65
mldsa87</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">It seems like the <code style='font-size: 90%; color: #18171d; word-wrap: break-word; border-radius: .25rem; background-color: #ececef; margin-top: 0; font-weight: inherit; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 0.125rem 0.25rem;'>tests/list-sign-algorithms.scm</code> is doing a bad job catching this because it is passing while a lot of values are missing.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I also found some missing pk-algorithms (which the list-pk-algorithm test found).
mlkem768
mldsa44
mldsa65
mldsa87
mlkem1024</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Is there a better way than manually checking the gnutls.h header and comparing?</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Also I am a bit confused on the ordering in <code style='font-size: 90%; color: #18171d; word-wrap: break-word; border-radius: .25rem; background-color: #ececef; margin-top: 0; font-weight: inherit; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 0.125rem 0.25rem;'>guile/modules/gnutls/modules/build/enums.scm</code> and the export in <code style='font-size: 90%; color: #18171d; word-wrap: break-word; border-radius: .25rem; background-color: #ececef; font-weight: inherit; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; white-space: pre-wrap; overflow-wrap: break-word; word-break: keep-all; padding: 0.125rem 0.25rem;'>guile/modules/gnutls.in</code> . I would expect the order to match the order from the enum but with the sign-algorithms at least it does not hold true making it difficult to compare with the enum declaration .</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Havent checked other enums for completeness.</p>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">Some of these have only been introduced in recent gnutls versions but the GNUTLS_SIGN_ECDSA_SHA256 from my certificate has been available in gnutls since version 2.99.2 (released 2011-05-26). Maybe this can be automated in some way?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/guile/-/issues/31#note_2373988580">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/1df1940d8ee1d5d44c606d5c3b2ff88f/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/guile/-/issues/31#note_2373988580"}}</script>
</p>
</div>
</body>
</html>