<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p class="details" style="font-style: italic; color: #626168;">
<a href="https://gitlab.com/ZoltanFridrich">Zoltán Fridrich</a> created an issue: <a href="https://gitlab.com/gnutls/gnutls/-/issues/1680">#1680</a>
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">p11tool manpage is written in a way that implies that only one Token is specified by URL, however, PKCS <a href="https://gitlab.com/gnutls/gnutls/-/issues/11" data-reference-type="issue" data-original="#11" data-link="false" data-link-reference="false" data-issue="240725" data-project="179611" data-iid="11" data-namespace-path="gnutls/gnutls" data-project-path="gnutls/gnutls" data-issue-type="issue" data-container="body" data-placement="top" title="Gnutls should use MSG_NOSIGNAL when writing to a socket" class="gfm gfm-issue" style="margin-top: 0;">#11 (closed)</a> URI allows matching rules (see <a href="https://datatracker.ietf.org/doc/html/rfc7512#section-2.5" rel="nofollow noreferrer noopener" target="_blank">https://datatracker.ietf.org/doc/html/rfc7512#section-2.5</a>) that allows one URI to match multiple tokens. This should be reflected in p11tool manpage. Incorrect wording is present in multiple sections of manpage and whole manpage should be reviewed. Couple of picked examples and suggested improvements are below.</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Version-Release number of selected component (if applicable):
gnutls-utils-3.6.14-7.el8_3.x86_64</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Actual state:</p>
<ol dir="auto" style="text-align: initial; margin: 0 0 1rem; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">
<p style="color: #3a383f; margin: 0 0 1rem;">Object listing
--list-all
List all available objects in a token.
All objects available in the token will be listed.</p>
</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">
<p style="color: #3a383f; margin: 0 0 1rem;">Key generation
--generate-privkey=string
Generate private-public key pair of given type.
Generates a private-public key pair in the specified token.</p>
</li>
</ol>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">Suggested improvement:
1a) Object listing
--list-all
List all available objects.
All available objects will be listed.
1b) Object listing
--list-all
List all available objects in a tokens matching specified URI.
All objects available in the tokens matching URI will be listed.</p>
<ol start="2" dir="auto" style="text-align: initial; margin: 0 0 1rem; padding: 0;">
<li style="margin-top: 0; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Key generation
--generate-privkey=string
Generate private-public key pair of given type.
Generates a private-public key pair in the specified token. Provided URI must match single token.</li>
</ol>
<p dir="auto" style="color: #3a383f; margin: 0;" align="initial">Additional info:
In SYNOPSIS or DESCRIPTION section of manpage, it could be clarified that URI may match multiple tokens and for some operation URI matching single token should be provided. Sentence saying something like "For more details about URIs and matching rules see The PKCS <a href="https://gitlab.com/gnutls/gnutls/-/issues/11" data-reference-type="issue" data-original="#11" data-link="false" data-link-reference="false" data-issue="240725" data-project="179611" data-iid="11" data-namespace-path="gnutls/gnutls" data-project-path="gnutls/gnutls" data-issue-type="issue" data-container="body" data-placement="top" title="Gnutls should use MSG_NOSIGNAL when writing to a socket" class="gfm gfm-issue" style="margin-top: 0;">#11 (closed)</a> URI Scheme" could be added.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/issues/1680">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/5f36503422f6a90ac6392b506e3baae6/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/-/issues/1680"}}</script>
</p>
</div>
</body>
</html>