<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/asosedkin">Alexander Sosedkin</a>
<a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/2058#note_3031254571">commented</a>:
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">And another one I found uses <code style='font-size: 90%; color: #18171d; word-wrap: break-word; background-color: #ececef; border-radius: .25rem; margin-top: 0; font-weight: inherit; overflow-wrap: break-word; white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;'>_gnutls_reallocarray</code>:</p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial"><a href="https://gitlab.com/gnutls/gnutls/-/blob/0c49dc6db376c2eccae98b0623dab60729d8f171/lib/cert-cred-x509.c#L1306" style="margin-top: 0;">https://gitlab.com/gnutls/gnutls/-/blob/0c49dc6db376c2eccae98b0623dab60729d8f171/lib/cert-cred-x509.c#L1306</a></p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial"><a href="https://gitlab.com/gnutls/gnutls/-/blob/0c49dc6db376c2eccae98b0623dab60729d8f171/lib/cert-cred-x509.c#L1332" style="margin-top: 0;">https://gitlab.com/gnutls/gnutls/-/blob/0c49dc6db376c2eccae98b0623dab60729d8f171/lib/cert-cred-x509.c#L1332</a></p>
<p dir="auto" style="color: #3a383f; margin: 0 0 1rem;" align="initial">I used a delightfully low-fi and non-comprehensive approach to identify the suspicious places: mixed mentions within curly bracket blocks:</p>
<div class="gl-relative markdown-code-block js-markdown-code" style="margin-bottom: 0;">
<pre class="code highlight js-syntax-highlight language-plaintext" v-pre="true" style='display: block; font-size: 14px; color: #3a383f; line-height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; margin: 0 0 1rem; padding: 12px; border: 1px solid #dcdcde;'><code style='font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-all; background-color: inherit; border-radius: .25rem; white-space: pre; margin-top: 0; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida console", monospace; font-variant-ligatures: none; overflow-wrap: normal; padding: unset;'><span id="LC1" class="line" lang="plaintext" style="margin-top: 0;">#/usr/bin/env python</span>
<span id="LC2" class="line" lang="plaintext"># public domain, trivial</span>
<span id="LC3" class="line" lang="plaintext"></span>
<span id="LC4" class="line" lang="plaintext">import sys</span>
<span id="LC5" class="line" lang="plaintext">import re</span>
<span id="LC6" class="line" lang="plaintext">from pathlib import Path</span>
<span id="LC7" class="line" lang="plaintext"></span>
<span id="LC8" class="line" lang="plaintext">ALLOCATOR_RELATED_FUNCTIONS = [</span>
<span id="LC9" class="line" lang="plaintext"> ['malloc', 'calloc', 'realloc', 'strdup', 'free'],</span>
<span id="LC10" class="line" lang="plaintext"> ['gnutls_malloc', 'gnutls_calloc', 'gnutls_realloc', 'gnutls_realloc_fast',</span>
<span id="LC11" class="line" lang="plaintext"> '_gnutls_reallocarray', '_gnutls_reallocarray_fast', 'gnutls_strdup',</span>
<span id="LC12" class="line" lang="plaintext"> 'gnutls_free', 'gnutls_zfree']</span>
<span id="LC13" class="line" lang="plaintext">]</span>
<span id="LC14" class="line" lang="plaintext"></span>
<span id="LC15" class="line" lang="plaintext">for filepath in sorted(sys.argv[1:]):</span>
<span id="LC16" class="line" lang="plaintext"> content = Path(filepath).read_text()</span>
<span id="LC17" class="line" lang="plaintext"> if content.count('{') != content.count('}'):</span>
<span id="LC18" class="line" lang="plaintext"> print(f'{filepath} has curly brace mismatch')</span>
<span id="LC19" class="line" lang="plaintext"> continue</span>
<span id="LC20" class="line" lang="plaintext"></span>
<span id="LC21" class="line" lang="plaintext"> stack, blocks = [], []</span>
<span id="LC22" class="line" lang="plaintext"> for i, char in enumerate(content):</span>
<span id="LC23" class="line" lang="plaintext"> if char == '{':</span>
<span id="LC24" class="line" lang="plaintext"> stack.append(i)</span>
<span id="LC25" class="line" lang="plaintext"> elif char == '}':</span>
<span id="LC26" class="line" lang="plaintext"> blocks.append((stack.pop(), i))</span>
<span id="LC27" class="line" lang="plaintext"></span>
<span id="LC28" class="line" lang="plaintext"> for start, end in blocks:</span>
<span id="LC29" class="line" lang="plaintext"> block_text = content[start:end+1]</span>
<span id="LC30" class="line" lang="plaintext"></span>
<span id="LC31" class="line" lang="plaintext"> families = []</span>
<span id="LC32" class="line" lang="plaintext"> for family in ALLOCATOR_RELATED_FUNCTIONS:</span>
<span id="LC33" class="line" lang="plaintext"> funcs = [f for f in family if re.search(rf'\b{f}\b', block_text)]</span>
<span id="LC34" class="line" lang="plaintext"> if funcs:</span>
<span id="LC35" class="line" lang="plaintext"> families.append(funcs)</span>
<span id="LC36" class="line" lang="plaintext"></span>
<span id="LC37" class="line" lang="plaintext"> if len(families) > 1:</span>
<span id="LC38" class="line" lang="plaintext"> start_line = content[:start].count('\n') + 1</span>
<span id="LC39" class="line" lang="plaintext"> end_line = content[:end].count('\n') + 1</span>
<span id="LC40" class="line" lang="plaintext"> print(f'{filepath}:{start_line}-{end_line}: might mix up ' +</span>
<span id="LC41" class="line" lang="plaintext"> ' with '.join(['/'.join(funcs) for funcs in families]))</span></code></pre>
<copy-code></copy-code><insert-code-snippet></insert-code-snippet>
</div>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/2058#note_3031254571">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/2-2ntjp25e2c4y6226k3u5n2lhz/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.com/gnutls/gnutls/-/merge_requests/2058#note_3031254571 at 1769196263
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/2058#note_3031254571"}}</script>
</p>
</div>
</body>
</html>