<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<p class="details" style="font-style: italic; color: #626168;">
Issue created by <a href="https://gitlab.com/swathipanneerselvam">swathipanneerselvam</a>: <a href="https://gitlab.com/gnutls/gnutls/-/work_items/1902">#1902</a>
</p>
<div class="md" style="position: relative; z-index: 1; color: #3a383f; word-wrap: break-word;">
<h2 id="user-content-description-of-problem" dir="auto" style="margin-top: 0px; margin-bottom: 10px;" align="initial">Description of problem:<a href="#description-of-problem" aria-label="Link to heading 'Description of problem:'" data-heading-content="Description of problem:" class="anchor" style="margin-top: 0px;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">In tests/pkcs11/pkcs11-mock4.c (added in MR <a href="https://gitlab.com/gnutls/gnutls/-/merge_requests/2041" title="Release 3.8.11" class="gfm gfm-merge_request" data-original="!2041" data-link="false" data-link-reference="false" data-merge-request="433177349" data-project="179611" data-project-path="gnutls/gnutls" data-iid="2041" data-container="body" data-placement="top" data-reference-type="merge_request" style="margin-top: 0px;">!2041 (merged)</a> for CVE-2025-9820), the assertion checking C_Initialize flags is a no-op due to C operator precedence:</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">c
assert(!(init_args->flags & LOCK_FLAGS) != LOCK_FLAGS);</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">! binds tighter than !=, so this evaluates as (0 or 1) != LOCK_FLAGS — always true since LOCK_FLAGS is a multi-bit constant. The mock never actually validates the initialization behavior.</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Fix should be either:
c
assert(!(init_args->flags & LOCK_FLAGS));</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">or:
c
assert((init_args->flags & LOCK_FLAGS) != LOCK_FLAGS);</p>
<h2 id="user-content-version-of-gnutls-used" dir="auto" style="margin-top: 20px; margin-bottom: 10px;" align="initial">Version of gnutls used:<a href="#version-of-gnutls-used" aria-label="Link to heading 'Version of gnutls used:'" data-heading-content="Version of gnutls used:" class="anchor" style="margin-top: 0px;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">3.8.10</p>
<h2 id="user-content-distributor-of-gnutls-eg-ubuntu-fedora-rhel" dir="auto" style="margin-top: 20px; margin-bottom: 10px;" align="initial">Distributor of gnutls (e.g., Ubuntu, Fedora, RHEL)<a href="#distributor-of-gnutls-eg-ubuntu-fedora-rhel" aria-label="Link to heading 'Distributor of gnutls (e.g., Ubuntu, Fedora, RHEL)'" data-heading-content="Distributor of gnutls (e.g., Ubuntu, Fedora, RHEL)" class="anchor" style="margin-top: 0px;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Amazon Linux 2023 (found while rebasing from c9s)</p>
<h2 id="user-content-how-reproducible" dir="auto" style="margin-top: 20px; margin-bottom: 10px;" align="initial">How reproducible:<a href="#how-reproducible" aria-label="Link to heading 'How reproducible:'" data-heading-content="How reproducible:" class="anchor" style="margin-top: 0px;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Always — the assertion is a compile-time tautology.</p>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Steps to Reproduce:</p>
<ul dir="auto" style="text-align: initial; list-style-type: disc; margin: 0px 0px 1rem; padding: 0;">
<li style="margin-top: 0px; line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Build gnutls 3.8.10 with the CVE-2025-9820 patch applied</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Run the pkcs11/long-label test</li>
<li style="line-height: 1.6em; margin-left: 25px; padding-left: 3px;">Observe that the assertion in override_C_Initialize passes regardless of what flags the caller sets</li>
</ul>
<h2 id="user-content-actual-results" dir="auto" style="margin-top: 20px; margin-bottom: 10px;" align="initial">Actual results:<a href="#actual-results" aria-label="Link to heading 'Actual results:'" data-heading-content="Actual results:" class="anchor" style="margin-top: 0px;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0px 0px 1rem;" align="initial">Assertion always passes. The mock accepts any combination of initialization flags without validating.</p>
<h2 id="user-content-expected-results" dir="auto" style="margin-top: 20px; margin-bottom: 10px;" align="initial">Expected results:<a href="#expected-results" aria-label="Link to heading 'Expected results:'" data-heading-content="Expected results:" class="anchor" style="margin-top: 0px;"></a>
</h2>
<p dir="auto" style="color: #3a383f; margin: 0px;" align="initial">Assertion should fail if the caller passes unexpected flags, validating the expected 3.8.10 C_Initialize behavior as the comment in the code describes.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #626168;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/-/work_items/1902">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.com">gitlab.com</a>. <a href="https://gitlab.com/-/sent_notifications/5-dnoxcqatf8ycow6mh1tsu8q41-a84t7/unsubscribe" target="_blank" rel="noopener noreferrer">Unsubscribe</a> from this thread · <a href="https://gitlab.com/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.com/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
<span style="color: transparent; font-size: 0; display: none; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.com/gnutls/gnutls/-/work_items/1902 at 1781024743
</span>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Work item","url":"https://gitlab.com/gnutls/gnutls/-/work_items/1902"}}</script>
</p>
</div>
</body>
</html>