[PATCH] pinentry-gtk-2: Fix ERROR: could not grab keyboard

[Ed Martin]

I already fixed this and submitted it to the list long ago (and i'm not about to search for it), it got lost to the spam and never committed. The problem is X does send an event when the window is visible (instead of just mapped) but gtk does not offer this signal by default, and the keyboard needs to be grabbed when it is visible. Debian's list was not full of spam and has already accepted my patch.

Anyways, a like to a patch that addresses the problem instead of fixing it.

http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=27;bug=401957

Maybe someone can commit it upstream this time.

On Apr 27, 2010, at 11:26 AM, Stanislav Ochotnicky wrote:

> On 04/27/2010 04:36 PM, Stanislav Ochotnicky wrote:
>> This patch adds 50ms timer before actually trying to grab
>> keyboard. Simple tests showed that this is enough to fix grabbing
>> failure and 50ms should be fast enought to prevent sniffing of
>> keyboard input.
> 
> Now that I think about it...maybe it would be best if we kept trying to
> grab keyboard every X ms until we get it? Meanwhile if pinentry is
> configured to use global grab and we don't have it yet, display BIG RED
> WARNING. pinentry is not long running application so this should not
> have that significant impact on performance...what do you think?
> 
> -- 
> Stanislav Ochotnicky <sochotnicky at redhat.com>
> Associate Software Engineer - Base Operating Systems Brno
> 
> Mobile: +420 775 633 759
> Red Hat Inc.                               http://cz.redhat.com
> 
> 
> _______________________________________________
> Gpa-dev mailing list
> Gpa-dev at gnupg.org
> http://lists.gnupg.org/mailman/listinfo/gpa-dev