From ueno at unixuser.org Wed Aug 10 05:59:23 2011 From: ueno at unixuser.org (Daiki Ueno) Date: Wed, 10 Aug 2011 12:59:23 +0900 Subject: Link against ncursesw In-Reply-To: <1311337433-sup-5456@sochotnicky.usersys.redhat.com> (Stanislav Ochotnicky's message of "Fri, 22 Jul 2011 14:30:51 +0200") References: <1311337433-sup-5456@sochotnicky.usersys.redhat.com> Message-ID: Hi, Stanislav Ochotnicky writes: > Fedora recently received a valid bugreport [1] showing problems with > pinentry-curses and UTF-8 descriptions (most visible when someone has > UTF-8 in their gnupg names). Most simple reproducer is: > > $ pinentry-curses > OK Your orders please > option lc-ctype=pl_PL.UTF-8 > OK > setdesc ?????????????????? > OK > getpin > [pinentry shows garbled text in curses] > > I prepared a patch that fixes this (attached), but I am not entirely > convinced it's the proper fix. That's mainly because I just replaced > ncurses linking with ncursesw. This is fine for most desktop systems > that have wide-char ncurses, but I assume there might be systems you > want to support without ncursesw. That reminds me of that I wrote a similar patch back in 2009: http://article.gmane.org/gmane.comp.encryption.gpg.devel/15428 which also addressed an issue that text frames are not rendered correctly when there is a double-width character on a line. I'm attaching a revised (and minimized) patch. > Apart from this does adding setlocale(LC_CTYPE, "") call seem > sensible? It would be good to respect lc-ctype option. -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Add-wide-char-support-to-pinentry-curses.patch Type: text/x-patch Size: 9908 bytes Desc: not available URL: -------------- next part -------------- Regards, -- Daiki Ueno From wk at gnupg.org Wed Aug 10 15:09:08 2011 From: wk at gnupg.org (Werner Koch) Date: Wed, 10 Aug 2011 15:09:08 +0200 Subject: Link against ncursesw In-Reply-To: (Daiki Ueno's message of "Wed, 10 Aug 2011 12:59:23 +0900") References: <1311337433-sup-5456@sochotnicky.usersys.redhat.com> Message-ID: <87ipq5s9aj.fsf@vigenere.g10code.de> On Wed, 10 Aug 2011 05:59, ueno at unixuser.org said: > I'm attaching a revised (and minimized) patch. Applied. Salam-Shalom, Werner -- Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz. From wk at gnupg.org Wed Aug 10 15:13:57 2011 From: wk at gnupg.org (Werner Koch) Date: Wed, 10 Aug 2011 15:13:57 +0200 Subject: Link against ncursesw In-Reply-To: <1311337433-sup-5456@sochotnicky.usersys.redhat.com> (Stanislav Ochotnicky's message of "Fri, 22 Jul 2011 14:30:51 +0200") References: <1311337433-sup-5456@sochotnicky.usersys.redhat.com> Message-ID: <87bovxs92i.fsf@vigenere.g10code.de> On Fri, 22 Jul 2011 14:30, sochotnicky at redhat.com said: > I prepared a patch that fixes this (attached), but I am not entirely > convinced it's the proper fix. That's mainly because I just replaced > ncurses linking with ncursesw. This is fine for most desktop systems > that have wide-char ncurses, but I assume there might be systems you Do we still need this pacth after Ueno's patch? BTW, please send pinentry related stuff in the future to gnupg-devel. gpa--dev is only for GPA which is just one application using GnuPG. Shalom-Salam, Werner -- Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz. From wk at gnupg.org Fri Aug 26 11:15:05 2011 From: wk at gnupg.org (Werner Koch) Date: Fri, 26 Aug 2011 11:15:05 +0200 Subject: GPA repository migrated to GIT Message-ID: <87obzcttye.fsf@vigenere.g10code.de> Hi, I converted the old Subversion repository of GPA to GIT. Because wald.intevation.org does not support GIT, the git repo has been moved back to its old server. The new URL is git://git.gnupg.org/gpa.git Clone and pull as usual. I hope that the use of git will get life back into gpa development. Note that in contrast to GnuPG, GPA does not require any kind of copyright assignments to the FSF. Thus send your patches to this list. Salam-Shalom, Werner -- Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz.