From sochotnicky at redhat.com Fri Jul 22 14:30:51 2011 From: sochotnicky at redhat.com (Stanislav Ochotnicky) Date: Fri, 22 Jul 2011 14:30:51 +0200 Subject: Link against ncursesw Message-ID: <1311337433-sup-5456@sochotnicky.usersys.redhat.com> Fedora recently received a valid bugreport [1] showing problems with pinentry-curses and UTF-8 descriptions (most visible when someone has UTF-8 in their gnupg names). Most simple reproducer is: $ pinentry-curses OK Your orders please option lc-ctype=pl_PL.UTF-8 OK setdesc ?????????????????? OK getpin [pinentry shows garbled text in curses] I prepared a patch that fixes this (attached), but I am not entirely convinced it's the proper fix. That's mainly because I just replaced ncurses linking with ncursesw. This is fine for most desktop systems that have wide-char ncurses, but I assume there might be systems you want to support without ncursesw. Proper way to deal with this would probably be to fallback like this: ncursesw -> ncurses -> curses Apart from this does adding setlocale(LC_CTYPE, "") call seem sensible? [1] https://bugzilla.redhat.com/show_bug.cgi?id=704495 -- Stanislav Ochotnicky Software Engineer - Base Operating Systems Brno PGP: 7B087241 Red Hat Inc. http://cz.redhat.com -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Link-against-ncursesw-and-fix-display-of-wide-charac.patch Type: application/octet-stream Size: 1630 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: