[mod_gnutls-devel] Sugestions for configure.ac and add for autogen.sh

[Bas van den Dikkenberg]

Hi all,

I am new here but stil  i offerd dkg some help.

I have some suggestion for configure.ac to more like standards.

The biggeste issue I could find that lt_init was missing witch can cause m3 eerror during the automake process.
The rest you can read below :

By adding te suggestion I made, i think it improves the portability of mod_gnutls.
As far as I can see it solves some problems during the build on kfreebsd at least



Description: Updated configure.ac
 * AM_INIT_AUTOMAKE doesn't need any options any more
 * DNL not needed so removed
 * LT_INIT was missing needed tot initilize libtool witch can cause m4 erors during the automake proces
 * Added missing AC_CHECK_FUNCS AC_FUNC_CHOWN
 * Added an autoconf.sh file
 .

Author: Bastiaan Franciscus van den Dikkenberg <bas at dikkenberg.net>

---
Last-Update: <2014-02-23>

--- mod-gnutls-0.6.orig/configure.ac
+++ mod-gnutls-0.6/configure.ac
@@ -1,4 +1,3 @@
-dnl
 AC_INIT(mod_gnutls, 0.6)
 OOO_CONFIG_NICE(config.nice)
 MOD_GNUTLS_VERSION=AC_PACKAGE_VERSION
@@ -9,7 +8,8 @@ AC_CONFIG_AUX_DIR(config)
 OOO_MAINTAIN_MODE
 AM_MAINTAINER_MODE
 AC_CANONICAL_TARGET
-AM_INIT_AUTOMAKE(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)
+AM_INIT_AUTOMAKE
+LT_INIT
 AM_CONFIG_HEADER(include/mod_gnutls_config.h:config.in)

 AC_SUBST(MOD_GNUTLS_VERSION)
@@ -40,7 +40,16 @@ SRP_CFLAGS=""
 if test "$use_srp" != "no"; then
        SRP_CFLAGS="-DENABLE_SRP=1"
 fi
-
+AC_CHECK_FUNCS([memchr])
+AC_CHECK_FUNCS([memmove])
+AC_CHECK_FUNCS([strcasecmp])
+AC_FUNC_CHOWN
+AC_FUNC_MALLOC
+AC_FUNC_REALLOC
+AC_TYPE_SIZE_T
+AC_TYPE_SSIZE_T
+AC_PROG_LN_S
+AC_PROG_MAKE_SET
 AC_MSG_CHECKING([whether to enable SRP functionality])
 AC_MSG_RESULT($use_srp)

@@ -61,6 +70,10 @@ fi
 AC_MSG_CHECKING([whether to enable MSVA functionality])
 AC_MSG_RESULT($use_msva)

+
+
+
+
 have_apr_memcache=0
 CHECK_APR_MEMCACHE([have_apr_memcache=1], [have_apr_memcache=0])
 AC_SUBST(have_apr_memcache)
--- /dev/null
+++ mod-gnutls-0.6/autogen.sh
@@ -0,0 +1,8 @@
+#!/bin/sh
+# autogen.sh - generates configure using the autotools
+libtoolize --force --copy
+aclocal -I m4
+autoheader
+automake --add-missing --copy --foreign
+autoconf
+rm -rf autom4te.cache