[mod_gnutls-devel] msva validation error handling

Daniel Kahn Gillmor dkg at fifthhorseman.net
Thu Mar 13 04:32:50 CET 2014


On 03/12/2014 11:05 PM, Clint Adams wrote:
> On Wed, Mar 12, 2014 at 03:03:07PM -0400, Daniel Kahn Gillmor wrote:
>> Clint, what do you think?
> 
> The fixes seem good.
> 
> The calloc fix is setting `sz' to 0.  Your patch is not.
> This leads me to wonder why `sz' was added in the first place
> and why it's not being used in any way.

i agree, sz is puzzling.  perhaps it should be removed?  This is
technically an ABI change, i think, but i don't know that it necessarily
matters.

	--dkg


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1010 bytes
Desc: OpenPGP digital signature
URL: </pipermail/attachments/20140312/df5444bc/attachment.sig>


More information about the mod_gnutls-devel mailing list