[mod_gnutls-devel] msv_ctxt_init() cleanup

Daniel Kahn Gillmor dkg at fifthhorseman.net
Tue Mar 18 22:18:01 CET 2014

Hi Ramkumar--

I think the message below is about libmsv, not mod_gnutls, right?

I'm fine using this mailing list to discuss libmsv work (though if Clint
would prefer it happen somewhere else, i defer to his preference), but
please make it clear which project a patch applies to in the message
someplace to avoid confusion.

(one comment inline, below)

On 03/18/2014 05:09 PM, Ramkumar Chinchani wrote:
> Test code cleanup after recent code changes.
> diff --git a/checkmsva.c b/checkmsva.c
> index 1c64977..aaa3133 100644
> --- a/checkmsva.c
> +++ b/checkmsva.c
> @@ -17,6 +17,7 @@
>  #include <stdlib.h>
>  #include <stdio.h>
> +#include <signal.h>
>  #include "msv/msv.h"

signal.h doesn't seem to be needed by the rest of this patch; does it
belong in a different changeset?

Thanks for your attention to detail, keep these patches coming!



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1010 bytes
Desc: OpenPGP digital signature
URL: </pipermail/attachments/20140318/6741a38f/attachment.sig>

More information about the mod_gnutls-devel mailing list