Some problems on Solaris

Werner Koch wk at isil.d.shuttle.de
Mon Feb 15 19:56:35 CET 1999


Steven Bakker <steven at icoe.att.com> writes:

> Note that in various spots in the source code, arrays are defined as
> "words[64]", without any explanation as to where the "64" comes from.

This is from the definition of MD5.   

> "http.c" is one that caused me headaches to debug, but I found more

I don't see any fixed size array in http.c ???

> examples of this.  Not to be pedantic, but I would still like to point out
> what _I_ learned in early SE/programming classes: Any constant (literal)
> value other than 0 or 1 should be declared as a symbol and referenced by

And I also use constants when they come from the definition of an
algorithm - anyway, i did not wrote the md5 code (see the different
indentatiuon style).

> code thinking a buffer is X+Y bytes while it is in fact X.

I'll try again on an alpha.


   Werner


-- 
ceterum censeo RSA esse delendam





More information about the Gnupg-devel mailing list