Suspicious about sign_ecdsa

NIIBE Yutaka gniibe at
Wed Sep 25 09:57:36 CEST 2013

Very minor thing.

While I read the function (sign_ecdsa of ecc.c), I think that the
error code of following part is not appropriate.

          if (_gcry_mpi_ec_get_affine (x, NULL, &I, ctx))
              if (DBG_CIPHER)
                log_debug ("ecc sign: Failed to get affine coordinates\n");
              err = GPG_ERR_BAD_SIGNATURE;
              goto leave;

This error occurs only if we have coding error or the curve is
invalid (... or hardware error).

GPG_ERR_INTERNAL would be appropriate.

More information about the Gcrypt-devel mailing list