[git] GCRYPT - branch, master, updated. libgcrypt-1.6.0-33-g04cda6b

by Milan Broz cvs at cvs.gnupg.org
Tue Jan 14 16:40:00 CET 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The GNU crypto library".

The branch, master has been updated
       via  04cda6b7cc16f3f52c12d9d3e46c56701003496e (commit)
       via  dfde161355b15b25b1d1214d5ee0338e50b33517 (commit)
      from  5f2af6c26bc04975c0b518881532871d7387d7ce (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 04cda6b7cc16f3f52c12d9d3e46c56701003496e
Author: Milan Broz <gmazyland at gmail.com>
Date:   Mon Jan 13 21:30:42 2014 +0100

    PBKDF2: Use gcry_md_reset to speed up calculation.
    * cipher/kdf.c (_gcry_kdf_pkdf2): Use gcry_md_reset
    to speed up calculation.
    Current PBKDF2 implementation uses gcry_md_set_key in every iteration
    which is extremely slow (even in comparison with other implementations).
    Use gcry_md_reset instead and set key only once.
    With this test program:
      char input[32000], salt[8], key[16];
      gcry_kdf_derive(input, sizeof(input), GCRY_KDF_PBKDF2,
                      salt, sizeof(salt), 100000, sizeof(key), key);
    running time without patch:
      real    0m11.165s
      user    0m11.136s
      sys     0m0.000s
    and with patch applied
      real    0m0.230s
      user    0m0.184s
      sys     0m0.024s
    (The problem was found when cryptsetup started to use gcrypt internal PBKDF2
    and for very long keyfiles unlocking time increased drastically.
    See https://bugzilla.redhat.com/show_bug.cgi?id=1051733)
    Signed-off-by: Milan Broz <gmazyland at gmail.com>

diff --git a/cipher/kdf.c b/cipher/kdf.c
index 503f068..af0dc48 100644
--- a/cipher/kdf.c
+++ b/cipher/kdf.c
@@ -175,19 +175,21 @@ _gcry_kdf_pkdf2 (const void *passphrase, size_t passphraselen,
       return ec;
+  ec = _gcry_md_setkey (md, passphrase, passphraselen);
+  if (ec)
+    {
+      _gcry_md_close (md);
+      xfree (sbuf);
+      return ec;
+    }
   /* Step 3 and 4. */
   memcpy (sbuf, salt, saltlen);
   for (lidx = 1; lidx <= l; lidx++)
       for (iter = 0; iter < iterations; iter++)
-          ec = _gcry_md_setkey (md, passphrase, passphraselen);
-          if (ec)
-            {
-              _gcry_md_close (md);
-              xfree (sbuf);
-              return ec;
-            }
+          _gcry_md_reset (md);
           if (!iter) /* Compute U_1:  */
               sbuf[saltlen]     = (lidx >> 24);

commit dfde161355b15b25b1d1214d5ee0338e50b33517
Author: Werner Koch <wk at gnupg.org>
Date:   Thu Jan 9 19:14:09 2014 +0100

    Add DCO entry for Milan Broz.

diff --git a/AUTHORS b/AUTHORS
index dc933dc..2c92998 100644
@@ -154,6 +154,9 @@ Jussi Kivilinna <jussi.kivilinna at mbnet.fi>
 Jussi Kivilinna <jussi.kivilinna at iki.fi>
 2013-05-06:5186720A.4090101 at iki.fi:
+Milan Broz <gmazyland at gmail.com>
+2014-01-13:52D44CC6.4050707 at gmail.com:
 Rafaël Carré <funman at videolan.org>
 2012-04-20:4F91988B.1080502 at videolan.org:


Summary of changes:
 AUTHORS      |    3 +++
 cipher/kdf.c |   16 +++++++++-------
 2 files changed, 12 insertions(+), 7 deletions(-)

The GNU crypto library

Gnupg-commits mailing list
Gnupg-commits at gnupg.org

More information about the Gcrypt-devel mailing list