[PATCH] ECC: (flags param) is only for key generation

NIIBE Yutaka gniibe at fsij.org
Wed May 7 13:31:19 CEST 2014

On 2014-04-25 at 11:37 +0900, NIIBE Yutaka wrote:
> On 2014-04-25 at 09:39 +0900, NIIBE Yutaka wrote:
> > But, I think that "(flags param)" only makes sense for key generation.
> This is revised patch, full version.

I checked the history of the change.

	commit ed45fd2e60c88e2f005282e6eadd018b59dcf65b
	Author: Werner Koch <wk at gnupg.org>
	Date:   Fri Nov 8 09:53:32 2013 +0100

	    ecc: Make "noparam" the default and replace by "param".

	commit ba892a0a874c8b2a83dbf0940608cd7e2911ce01
	Author: Werner Koch <wk at gnupg.org>
	Date:   Fri Oct 25 15:44:03 2013 +0200

	    ecc: Add flags "noparam" and "comp".

It seems that it's intentional.

Let me confirm that

	(flags param)

is required for key when we don't use curvename.


  (1) We need to update the code which uses ECC to add (flags param)
      or use curvename.

  (2) We need to modify the code of libgcrypt itself to get flags of
      param from KEYPARMS.
      Specifically, ecc_sign and ecc_verify should be modified.
      Currently, ecc_sign and ecc_verify don't get flags from KEYPARMS,
      but only from DATA.

More information about the Gcrypt-devel mailing list