[PATCH] ECC: (flags param) is only for key generation

Werner Koch wk at gnupg.org
Wed May 7 17:44:31 CEST 2014

On Wed,  7 May 2014 13:31, gniibe at fsij.org said:

> It seems that it's intentional.

Right.  I looked at code using ECC fucntions of Libgcrypt and found that
this change won't break too much.  And if it breaks something it will
help to clean up that code.

> Let me confirm that
> 	(flags param)
> is required for key when we don't use curvename.

Yes.  But you should use curvename - it is much more efficient.

>   (1) We need to update the code which uses ECC to add (flags param)
>       or use curvename.

Right.  I fixed GnuPG today.

>   (2) We need to modify the code of libgcrypt itself to get flags of
>       param from KEYPARMS.
>       Specifically, ecc_sign and ecc_verify should be modified.
>       Currently, ecc_sign and ecc_verify don't get flags from KEYPARMS,
>       but only from DATA.

That is indeed a bug.  The param flag does not make sense in DATA.



Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.

More information about the Gcrypt-devel mailing list