[PATCH] CFB 8 Bit implementation

[Mathias Baumann]

> I guess you should take at least one or two test vectors from http://
> csrc.nist.gov/groups/STM/cavp/block-ciphers.html#aes and add as a self test as
> you find in all other implementations.

> If you want to confirm your implementation, have all test vectors you find at
> the given URL processed by your implementation.


I have used the vectors found at http://csrc.nist.gov/publications/nistpubs/800-38a/sp800-38a.pdf

which is also what the other tests in that file use. Unfortunately that document didn't seem to provide vectors >1 byte.

Neither does your link though.


I did test the implementation with numerous internal tests in our applications that previously worked with the mcrypt library.


With those tests and my own I am fairly confident about the implementation.


However if you wish to see all those tests implemented before accepting the patch, I can do that.


cheers,


--Marenz

________________________________
From: Stephan Müller <smueller at chronox.de>
Sent: 25 January 2017 14:27:58
To: gcrypt-devel at gnupg.org
Cc: Mathias Baumann
Subject: Re: [PATCH] CFB 8 Bit implementation

Am Dienstag, 24. Januar 2017, 15:43:31 CET schrieb Mathias L. Baumann:

Hi Mathias,

> Hello dear Gcrypt Devs,
>
> as a followup to Lizas request/inqueries I now implemented CFB in 8 bit
> mode.
>
> Please let me know about any changes you want to see.
>
> I should add that my stack burning code is more or less just guessing
> how it should be done by imitating what I saw in the other functions.
> Please validate that I did that correct :)

I guess you should take at least one or two test vectors from http://
csrc.nist.gov/groups/STM/cavp/block-ciphers.html#aes and add as a self test as
you find in all other implementations.

If you want to confirm your implementation, have all test vectors you find at
the given URL processed by your implementation.
>
>
> The patch is attached and can also found at
> https://github.com/mathias-baumann-sociomantic/libgcrypt/tree/cfb8
>
> cheers,
>
>      --Mathias Baumann



Ciao
Stephan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/attachments/20170125/ea4a2d0e/attachment-0001.html>