[PATCH] CFB 8 Bit implementation
jussi.kivilinna at iki.fi
Fri Jan 27 18:59:49 CET 2017
On 24.01.2017 16:43, Mathias L. Baumann wrote:
> Hello dear Gcrypt Devs,
> as a followup to Lizas request/inqueries I now implemented CFB in 8 bit mode.
> Please let me know about any changes you want to see.
Looks mostly ok, just few requests:
- Change '//' C++ style comments to /* .. */
- Add few multibyte test-vectors from  and .
- Add changelog to commit message, see other commit for example (see ).
- Send signed DCO to mailing list, and add 'Signed-off-by' to commit message (see ).
> I should add that my stack burning code is more or less just guessing how it should be done by imitating what I saw in the other functions.
> Please validate that I did that correct :)
Yes, it's done correctly.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 273 bytes
Desc: OpenPGP digital signature
More information about the Gcrypt-devel