[git] GCRYPT - branch, LIBGCRYPT-1-5-BRANCH, updated. libgcrypt-1.5.3-2-g497478c
by Werner Koch
cvs at cvs.gnupg.org
Mon Sep 16 16:28:18 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The GNU crypto library".
The branch, LIBGCRYPT-1-5-BRANCH has been updated
via 497478c79711eee5a032ea91e9d7ad02a5a961cd (commit)
from 64b8f6b7d5d8fd40df2561dedf21729466d0412a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 497478c79711eee5a032ea91e9d7ad02a5a961cd
Author: Werner Koch <wk at gnupg.org>
Date: Sat Sep 7 10:06:46 2013 +0200
Fix bug in _gcry_mpi_tdiv_q_2exp.
* mpi/mpi-internal.h (MPN_COPY_INCR): Make it work.
--
This bug has been with us since the version 0.0.0 of GnuPG.
Fortunately it only affects an optimized code path which is rarely
used in practice: If the shift size matches the size of a
limb (i.e.. 32 or 64); this is is_prime in primegen.c. Over there the
Rabin-Miller test may fail with a probability of 2^-31 (that is if the
to be tested prime - 1 has the low 32 bits cleared). In practice the
probability is even much less because we first do a Fermat test on the
randomly generated candidates which sorts out the majority of
composite numbers.
The bug in MPN_COPY_INCR was found by Sven Bjorn.
Signed-off-by: Werner Koch <wk at gnupg.org>
(cherry picked from commit a7a9cdcaaf3979baa18dad51e722882581349f45)
diff --git a/THANKS b/THANKS
index 0f47d4f..6a44ead 100644
--- a/THANKS
+++ b/THANKS
@@ -135,6 +135,7 @@ Steffen Ullrich ccrlphr at xensei.com
Steffen Zahn zahn at berlin.snafu.de
Steven Bakker steven at icoe.att.com
Susanne Schultz schultz at hsp.de
+Sven Bjorn
Szakats Istvan szaki.ms at gmail.com
Thiago Jung Bauermann jungmann at cwb.matrix.com.br
Thomas Roessler roessler at guug.de
diff --git a/mpi/mpi-internal.h b/mpi/mpi-internal.h
index e75b7c6..8ba1d79 100644
--- a/mpi/mpi-internal.h
+++ b/mpi/mpi-internal.h
@@ -92,7 +92,7 @@ typedef int mpi_size_t; /* (must be a signed type) */
do { \
mpi_size_t _i; \
for( _i = 0; _i < (n); _i++ ) \
- (d)[_i] = (d)[_i]; \
+ (d)[_i] = (s)[_i]; \
} while (0)
#define MPN_COPY_DECR( d, s, n ) \
-----------------------------------------------------------------------
Summary of changes:
THANKS | 1 +
mpi/mpi-internal.h | 2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
hooks/post-receive
--
The GNU crypto library
http://git.gnupg.org
More information about the Gnupg-commits
mailing list