[git] GnuPG - branch, STABLE-BRANCH-1-4, updated. gnupg-1.4.14-5-g9dc6dd0
by Werner Koch
cvs at cvs.gnupg.org
Mon Sep 16 16:36:25 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The GNU Privacy Guard".
The branch, STABLE-BRANCH-1-4 has been updated
via 9dc6dd0572102a2fa27df28ba4d66728827eb03d (commit)
from 45efde9557661ea071a01bcb938f1591ed4ec1a3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9dc6dd0572102a2fa27df28ba4d66728827eb03d
Author: Werner Koch <wk at gnupg.org>
Date: Mon Sep 16 15:57:01 2013 +0200
Fix bug in mpi_tdiv_q_2exp.
* mpi/mpi-internal.h (MPN_COPY_INCR): Make it work.
--
This bug has been with us since the version 0.0.0 of GnuPG.
Fortunately it only affects an optimized code path which is rarely
used in practice: If the shift size matches the size of a
limb (i.e.. 32 or 64); this is is_prime in primegen.c. Over there the
Rabin-Miller test may fail with a probability of 2^-31 (that is if the
to be tested prime - 1 has the low 32 bits cleared). In practice the
probability is even much less because we first do a Fermat test on the
randomly generated candidates which sorts out the majority of
composite numbers.
The bug in MPN_COPY_INCR was found by Sven Bjorn.
Signed-off-by: Werner Koch <wk at gnupg.org>
(back ported from Libgcrypt
commit 7f7a5ef59962ae1a819b5060f9b781469bfe27d5)
diff --git a/mpi/mpi-internal.h b/mpi/mpi-internal.h
index c1df30a..46da08d 100644
--- a/mpi/mpi-internal.h
+++ b/mpi/mpi-internal.h
@@ -104,7 +104,7 @@ typedef int mpi_size_t; /* (must be a signed type) */
do { \
mpi_size_t _i; \
for( _i = 0; _i < (n); _i++ ) \
- (d)[_i] = (d)[_i]; \
+ (d)[_i] = (s)[_i]; \
} while (0)
#define MPN_COPY_DECR( d, s, n ) \
-----------------------------------------------------------------------
Summary of changes:
mpi/mpi-internal.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
hooks/post-receive
--
The GNU Privacy Guard
http://git.gnupg.org
More information about the Gnupg-commits
mailing list