[git] Pinentry - branch, master, updated. pinentry-0.9.7-2-g954da56

[by Andre Heinecke]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The standard pinentry collection".

The branch, master has been updated
       via  954da56c2325c3a5ca628cfc2e3086c1e146a390 (commit)
      from  65fa8d2e2a38ae3c6bf7398ae5feb872f8ce23fe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 954da56c2325c3a5ca628cfc2e3086c1e146a390
Author: Andre Heinecke <aheinecke at intevation.de>
Date:   Tue Jan 5 12:44:32 2016 +0100

    Qt: Fix use after free in quality calculation
    
    * qt/pinentrydialog.cpp (PinEntryDialog::updateQuality): Keep UTF8
     byte array alive after conversion.
    
    --
    Same problem pattern as in Bug 2133 / commit f143d216

diff --git a/qt/pinentrydialog.cpp b/qt/pinentrydialog.cpp
index c7885d3..81205ee 100644
--- a/qt/pinentrydialog.cpp
+++ b/qt/pinentrydialog.cpp
@@ -309,7 +309,8 @@ void PinEntryDialog::updateQuality(const QString & txt )
 
   if (!_have_quality_bar || !_pinentry_info)
     return;
-  const char* pin = txt.toUtf8().constData();
+  const QByteArray utf8_pin = txt.toUtf8 ();
+  const char* pin = utf8_pin.constData ();
   length = strlen (pin);
   percent = length? pinentry_inq_quality (_pinentry_info, pin, length) : 0;
   if (!length)

-----------------------------------------------------------------------

Summary of changes:
 qt/pinentrydialog.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
The standard pinentry collection
http://git.gnupg.org