[PATCH] fix agent/findkey.c

Werner Koch wk at gnupg.org
Fri Nov 2 15:31:05 CET 2012


On Thu,  1 Nov 2012 01:17, gniibe at fsij.org said:

> 1018         storage = *((type *) (arg_list[arg_counter++])); \
> 1019     }                                                    \
> 1020   while (0)
>
> Here (line 1018), it expects a _pointer_ to the type and it is

Argh. You are of course right.  I overlooked the the semantics of
ARG_NEXT.

Moritz implemented gcry_sexp_build_array back in 2003 when I was busy
renewing our house.  I recall that I had no real desk around that time
and was quite distracted from GnuPG stuff.  Thus I obviously missed to
comment on his new function.  Anyway, it is clearly my fault.  This
function should have non-surprising semantics.  It is too late now, we
can only document it and put a big warning into it.

I'll commit your fixes.


Shalom-Salam,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.




More information about the Gnupg-devel mailing list