[PINENTRY PATCH] add efl-based frontend

Justus Winter justus at g10code.com
Wed Oct 19 14:07:41 CEST 2016


Mike Blumenkrantz <michael.blumenkrantz at gmail.com> writes:
> On Thu, Oct 13, 2016 at 8:28 AM Justus Winter <justus at g10code.com> wrote:
>> The formatting of the commit message, however, does not.  Details can
>> be found in the already mentioned doc/HACKING file.  At the very least,
>> try to make it blend in with the other commit messages ;)
>
> Can you elaborate on exactly which parts need changes? I tried to follow
> the policy in that file, but there did not seem to be much which could
> apply to adding new frontends like this.

We write whole sentences, the first word starts with a capital letter,
and we end sentences with a period.  We include ChangeLog-style entries
for all affected files.  We start with a one-line summary that starts
with a component followed by a colon, a space, and a whole sentence.

All of that should be obvious by just averaging over some of the recent
commit messages even without looking at the documentation.

I realize that all of that is a matter of taste, and one cannot expect
everyone to hunt down the docs, and follow it to the letter.  I don't
believe we are particularly picky about this, but your message really
sticks out.


Cheers,
Justus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 454 bytes
Desc: not available
URL: </pipermail/attachments/20161019/f514f3f7/attachment.sig>


More information about the Gnupg-devel mailing list