[PINENTRY PATCH] add efl-based frontend

[Mike Blumenkrantz]

Hey, thanks for the quick feedback!

On Thu, Oct 13, 2016 at 8:28 AM Justus Winter <justus at g10code.com> wrote:

> Hi Mike :)
>
>
>
> Mike Blumenkrantz <zmike at samsung.com> writes:
>
> > Attached is a patch implementing an efl-based gui frontend for pinentry.
>
>
>
> Cool!
>
>
>
> > As a note, the formatting in pinentry-efl.c was done by using the
>
> > 'indent' tool; I am not familiar enough with this coding style to
>
> > manually make corrections if further changes are needed in this
>
> > regard.
>
>
>
> The formatting of the code looks nice, thanks.
>
>
>
> The formatting of the commit message, however, does not.  Details can
>
> be found in the already mentioned doc/HACKING file.  At the very least,
>
> try to make it blend in with the other commit messages ;)
>

Can you elaborate on exactly which parts need changes? I tried to follow
the policy in that file, but there did not seem to be much which could
apply to adding new frontends like this.


>
>
>
> > Thanks for your time and review,
>
>
>
> I tried to compile it, but failed to do so because it depends on a very
>
> recent libelementary which is only available from Debian experimental,
>
> and I failed to pull that in for some reason.
>
>
>
> In any case, that means that your pinentry won't be usable for the
>
> majority until the required version reaches end users.  You might want
>
> to try to relax this a little (though ofc I don't know anything about
>
> libelementary, so...).
>

Regrettably, reducing the version requirements is not possible in order for
the frontend to have readable text. I'm fine with it not being usable for
some number of users at this time.


>
>
>
> But I noticed that despite me using ../configure --enable-pinentry-efl,
>
> the failed version check was not fatal.  I'd say it should abort if the
>
> user explicitly asked for it but the requirements were not met.
>

Ah, I'll fix this, thanks.


>
>
>
>
>
> Cheers,
>
> Justus
>
> _______________________________________________
>
> Gnupg-devel mailing list
>
> Gnupg-devel at gnupg.org
>
> http://lists.gnupg.org/mailman/listinfo/gnupg-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/attachments/20161013/53f6a940/attachment.html>