[PATCH libgpg-error] gpgrt-config: escape expr(1) operands

NIIBE Yutaka gniibe at fsij.org
Fri Jan 18 01:13:53 CET 2019


NIIBE Yutaka <gniibe at fsij.org> wrote:
> I confirmed that the release of 1.33 and 1.34 have wrong gpgrt-config.

To reproduce the error, here is a scenario.  You can reproduce that the
old generated gpgrt-config is in the released tarball.

If your automake is diffent version to the one of author, you will see
minor differences of automake generated files.  Also, po/*.po will have
different time stamps.  If you stay in different timezone, your
generated ChangeLog date fields will be also different.

Except these differences, it is only the file gpgrt-config, which is
different.

Well, for reproducibility, it would be good to invoke
gitlog-to-changelog with European timezone in Makefile.

==========================
# Preparation
# (1) Insall tools needed (git, autoconf, automake, etc.)
# (2) Manually install gnupg/build-aux/gitlog-to-changelog to /usr/local/bin

$ mkdir build-libgpg-error

# Clone the libgpg-error package
$ git clone git://git.gnupg.org/libgpg-error.git
$ cd libgpg-error

# Go to the version which used to generate gpgrt-config
$ git checkout 1096ff7
# And build the tarballs
$ ./autogen.sh
$ cd ../build-libgpg-error
$ ../libgpg-error/configure --enable-maintainer-mode
$ make distcheck

# This produces files:
#	libgpg-error-1.33-beta40.swdb
#	libgpg-error-1.33-beta40.tar.bz2
#	libgpg-error-1.33-beta40.tar.gz

# Some clean up (to recover po/*.po files)
$ cd ../libgpg-error
$ git reset --hard

# Then, go to the released version of 1.34
$ git checkout libgpg-error-1.34
# And build the tarballs, with same BUILD directory (not cleaned)
$ ./autogen.sh
$ cd ../build-libgpg-error
$ make distcheck

# This produces files:
#	libgpg-error-1.34.swdb
#	libgpg-error-1.34.tar.bz2
#	libgpg-error-1.34.tar.gz

$ cd ../libgpg-error
$ git reset --hard
==========================

In libgpg-error-1.34.tar.bz2 or libgpg-error-1.34.tar.gz, we can see old
generated gpgrt-config.
-- 



More information about the Gnupg-devel mailing list