[gnutls-devel] valgrind-tests vs full-test-suite
nmav at gnutls.org
Wed Mar 15 05:42:43 CET 2017
On Tue, 2017-03-14 at 22:27 +0200, Alon Bar-Lev wrote:
> On 14 March 2017 at 15:34, Nikos Mavrogiannopoulos <nmav at gnutls.org>
> > On Tue, Mar 14, 2017 at 2:01 PM, Alon Bar-Lev <alon.barlev at gmail.co
> > m> wrote:
> > > > That's true but we have them enabled by default, so builds
> > > > would fail
> > > > for that reason and that would create more noise in the list.
> > > >
> > > > > In release tarball there is no full-suite.
> > > > > The result is that valgrind cannot be enabled unless the non-
> > > > > existence
> > > > > full-suite is disabled...
> > > > > So I do not think this logic is required.
> > > >
> > > > That's true, but I am afraid of the issue above (when this was
> > > > added
> > > > was specifically to avoid such reports from the list). It
> > > > should be
> > > > combined with another change that makes valgrind not to run by
> > > > default
> > > > on releases.
> > > Can we disable this by default and enable it explicitly in all ci
> > > jobs?
> > > Or can we add another flag that is disabled by default and when
> > > enabled will not touch the VALGRIND?
> > Makes sense.
> Hmmm... I probably did not understand what option "Makes sense" :)
Sorry, I meant the first one: "Can we disable this by default and
enable it explicitly in all ci jobs?"
> So I've done the first..., please checkout.
Thanks, commented on the MR.
More information about the Gnutls-devel