[gnutls-devel] GnuTLS | Add CI tarball build (!809)
Development of GNU's TLS library
gnutls-devel at lists.gnutls.org
Wed Nov 21 20:04:18 CET 2018
> - we add a function in `tests/scripts/common.sh` that exits with 77 (SKIP) if not running on bash. Let's name is `skip_if_not_bash()`.
> - add a call to skip_if_not_bash() for scripts that require bash
Wouldn't that mean that these tests will run only if `/bin/sh` is bash? In the freebsd runners bash is `/usr/local/bin/bash` and these tests are currently running there. With the new approach they will not.
> That means devs can focus on writing test scripts for bash. If they break the Alpine runner, the dev just adds a call to skip_if_not_bash() _or_ fixes the bashism. Whatever suits best.
Why cannot we install bash on alpine?
> This MR has more than fixing bashisms. There is also a signal/abort (SIGABRT) issue being fixed. And several usages of diff options (-I) have been replaced by grep. This is also pretty trivial.
Ok, let me check it in detail.
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/809#note_119164608
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Gnutls-devel