[gnutls-devel] GnuTLS | Add CI tarball build (!809)
Development of GNU's TLS library
gnutls-devel at lists.gnutls.org
Thu Nov 22 19:41:30 CET 2018
> > To run the test suite bash is required and it doesn't need to be in /bin/sh (that's why env is used).
> Can't see any usage of env except in one test. Maybe it is a future plan to use it (we should open an issue about it). It's a different thing, not directly related to this MR. But when at it: `#!/usr/sbin/env sh` as proposed won't start bash. It just finds sh even when not in /bin.
We do not have any script with `#!/usr/sbin/env sh`. We have `#!/usr/sbin/env bash` in `cert-tests/pkcs12-utf8`, `cert-tests/certtool`, and `gnutls-cli-debug.sh`.
> That's one type of user. There are several other types. And there are OSes that don't have latest GnuTLS in their repos. There are container builds, manual and automated, striving for a minimal build environment. Non of these is interested in a full-blown developer build with TLS fuzzer testing etc. All that is required is a `./configure && make && make check` - and the 'check' is just to test the basic functionality. If this can be run with a simple POSIX shell (and the busybox ash is maybe the best we can have here) just with trivial changes... well, then we should do it. If people want more - they should just install bash. we can easily document it.
Optional tests are a necessary evil and I do not think we should be introducing them, unless it is really necessary. It is very easy to skip them on an CI upgrade for example if the underlying OS changes some of the assumptions.
> This MR does it (the requested changes will likely be addressed tomorrow, when I have some time). And talking about future bash-only scripts is a bit theoretical right now. Let's discuss those test when they arrive to leave the academical area and go back to practice. And BTW, I never said that requiring bash is a _big obstacle_. It's just a small annoyance.
Ok, I may be going into a bikeshedding area, so ok, if we can remove the bash as a dependency lets try it. But we should have easy macros to achieve the same functionality and let's remove them completely (i.e., not make some of these tests optional).
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/809#note_119452744
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Gnutls-devel