[gnutls-devel] GnuTLS | WIP: RFC7250 Raw public keys (!650)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Sun Sep 16 18:15:19 CEST 2018

Tom commented on a discussion on lib/cert-cred-x509.c:

>  }
> -static int
> +int // REMARK: we need this function for raw public key support. Maybe rename with _gnutls_ prefix again?
>  certificate_credential_append_crt_list(gnutls_certificate_credentials_t res,
>  				       gnutls_privkey_t key,
>  				       gnutls_str_array_t names,
> -				       gnutls_pcert_st * crt, int nr)
> +				       gnutls_pcert_st * crt, int nr) //REMARK: why not call this function ..._append_keypair(). it is not clear from the name that it also appends a private key

Do you want me to change its name in a separate "cleanup / nice to have" patch?

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/650#note_101685785
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20180916/d05299ce/attachment.html>

More information about the Gnutls-devel mailing list