[gnutls-devel] GnuTLS | Minor fixes in 3.6.9 release (!1053)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Sun Aug 4 07:05:45 CEST 2019

Merge request https://gitlab.com/gnutls/gnutls/merge_requests/1053 was reviewed by Daiki Ueno

Daiki Ueno started a new discussion on src/Makefile.am: https://gitlab.com/gnutls/gnutls/merge_requests/1053#note_199847813

>  # case --enable-local-libopts: We do not call AUTOGEN unless the .bak files are missing
>  .def.stamp:
>  	@b=`echo $@ | sed 's/.stamp$$//'`; \

I would add `$(AM_V_GEN)` here, instead of inside the `if`, so `GEN foo.def` is always printed upon make.

Daiki Ueno started a new discussion on src/Makefile.am: https://gitlab.com/gnutls/gnutls/merge_requests/1053#note_199847814

>  	@b=`echo $@ | sed 's/.stamp$$//'`; \
> -	if ! test -f $${srcdir}$${b}.c.bak;then \
> +	if ! test -f $(srcdir)/$${b}.c.bak;then \

The original rule (still there below line 290) came from:

That said, the use of the shell variable `$srcdir` here was a bit redundant as automake always sets `$(srcdir)`.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/1053
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190804/ce90e2d0/attachment-0001.html>

More information about the Gnutls-devel mailing list