[gnutls-devel] GnuTLS | check_if_signed: ensure that git-rev-list command succeeds (!961)

[Development of GNU's TLS library]

Tim Rühsen started a new discussion on devel/check_if_signed:

>  # create list of commits of the current branch
>  commits=$(git rev-list --no-merges $CI_MERGE_REQUEST_TARGET_BRANCH_NAME..$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME)
>  
> +if test $? -ne 0;then

That's not how it works. I tried it locally with `a..b`, got the same error as mentioned in !960, the script stopped with `$?` being 0. Please see !962 for a working and more general approach (in case of command failure in other places).

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/961#note_154985964
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190328/c05896c2/attachment-0001.html>