[gnutls-devel] GnuTLS | DH and ECDH keys tests (!990)
Development of GNU's TLS library
gnutls-devel at lists.gnutls.org
Thu May 23 11:25:32 CEST 2019
My final review:
- In tests/*dh-compute.c the fail() arguments print __LINE__ and __func__ but these are already included in the output of fail()
- In lib/nettle/pk.c the FIPS check is only run when `PK_DERIVE_TLS13` flag is set. That means it will not be run under TLS1.2. Maybe a new flag to indicate known parameters?
- There is a typo in two of the commit messages 'paramters', and 'tLS 1.3'
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/990#note_173618113
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Gnutls-devel