[gnutls-devel] GnuTLS | WIP: Add option to store all stapled OCSP responses to gnutls-cli (!1189)

[Development of GNU's TLS library]

Tim Rühsen commented:


I think it would be good to have error messages in case something goes wrong. Staying silent may lead to wrong assumptions and hard to find issues later. Check all calls to fwrite/fclose and also print an error message when gnutls_ocsp_status_request_get2() fails.

Then why use PEM for SAVE_OCSP_MULTI and DER for SAVE_OCSP ? IMO it would be more consistent when both options use the same output format. What about checking the file extension (.pem | .der) and/or have another option to specify the output format ?

Else LGTM :-)

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1189#note_283814898
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200206/42545b02/attachment.html>