[gnutls-devel] GnuTLS | tests: split up system-override-sig-hash.sh (!1298)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Fri Jul 3 16:10:22 CEST 2020



Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1298 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on tests/system-override-hash.sh: https://gitlab.com/gnutls/gnutls/-/merge_requests/1298#note_373403370

> +# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> +
> +builddir="${builddir:-.}"

Not your fault, but I would write `: ${builddir=.}` so we don't need to quote.

--
  
Daiki Ueno started a new discussion on tests/system-override-hash.sh: https://gitlab.com/gnutls/gnutls/-/merge_requests/1298#note_373403374

> +export GNUTLS_SYSTEM_PRIORITY_FILE="${TMPFILE}"
> +
> +exec ${builddir}/system-override-hash

Not your fault too (because there is no cleanup logic in the original test), but we can't remove `TMPFILE` if we use `exec`.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1298
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200703/44f8f09f/attachment.html>


More information about the Gnutls-devel mailing list