[gnutls-devel] GnuTLS | specialize gnutls_load_file() for unix-like OS (!1270)

Development of GNU's TLS library gnutls-devel at lists.gnutls.org
Sat May 30 01:04:08 CEST 2020

Glenn Strauss created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1270

Project:Branches: gstrauss/gnutls:specialize-gnutls_load_file to gnutls/gnutls:master
Author:    Glenn Strauss

specialize `gnutls_load_file()` for unix-like OS

This implementation is safer, more secure, more robust, and more efficient than the existing generic implementation using system stdio.

reference: #1002

@dueno has committed some related improvements to gnulib http://git.savannah.gnu.org/gitweb/?p=gnulib.git

This patch for gnutls loads a file into a gnutls_datum_t, but most of this patch could alternatively be submitted to the gnulib implementation of `read_file()`.  Were that to be done, gnutls would retain the cost of double-copying the file contents in `gnutls_load_file()` when `gnutls_malloc != malloc`

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [x] Code modified for feature
 * [-] Test suite updated with functionality tests
 * [-] Test suite updated with negative tests
 * [-] Documentation updated / NEWS entry present (for non-trivial changes)
 * [-] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1270
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20200529/dc3db2d3/attachment.html>

More information about the Gnutls-devel mailing list