[gnutls-devel] GnuTLS | make insecure-hash filter out ciphersuites on ->prf as well (!1479)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Wed Oct 20 17:21:12 CEST 2021

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1479 was reviewed by Daiki Ueno

Daiki Ueno started a new discussion on lib/priority.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1479#note_709355079

>  	for (j=0;j<priority_cache->_cipher.num_priorities;j++) {
>  		for (z=0;z<priority_cache->_mac.num_priorities;z++) {
> +			if (priority_cache->cs.size == MAX_CIPHERSUITE_SIZE)

Is my understanding correct that this is expanded like this to avoid the unnecessary call to `cipher_suite_get`? As I expect the compiler would do this kind of job as part of optimization, I would suggest moving this `if` to [line 1698](https://gitlab.com/gnutls/gnutls/-/merge_requests/1479/diffs#dc3111175f1ef48ddba45e288e07e48088695bdb_1689_1698), as it would be a little clearer why `cs.size` is checked.

Daiki Ueno started a new discussion on lib/priority.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1479#note_709355086

>  		for (j=0;j<priority_cache->_cipher.num_priorities;j++) {
>  			for (z=0;z<priority_cache->_mac.num_priorities;z++) {
> +				if (priority_cache->cs.size == MAX_CIPHERSUITE_SIZE)

Same here.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1479
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211020/7d0de905/attachment.html>

More information about the Gnutls-devel mailing list